[JIRA] (JENKINS-57903) New PromotionProcess,PromotionCondition and PromotionConditionDescriptor classes for the plugin.

35 views
Skip to first unread message

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 7, 2019, 3:20:03 AM6/7/19
to jenkinsc...@googlegroups.com
Prastik Gyawali created an issue
 
Jenkins / Task JENKINS-57903
New PromotionProcess,PromotionCondition and PromotionConditionDescriptor classes for the plugin.
Issue Type: Task Task
Assignee: Prastik Gyawali
Components: promoted-builds-plugin
Created: 2019-06-07 07:19
Labels: gsoc-2019 gsoc2019-artifact-promotion-in-pipeline
Priority: Minor Minor
Reporter: Prastik Gyawali

Before implementing the promotion-conditions(Self and Manual Conditions), it seems necessary to build new abstract/classes for the following existing classes.

  • PromotionProcess
  • PromotionCondition
  • PromotionConditionDescriptor

For readability ease all these classes are being added by the word "Pipeline" as their prefix.

Three new analogous classes are being made retaining some of the original functions and will timely be updated as other classes start depending on them.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 7, 2019, 3:21:02 AM6/7/19
to jenkinsc...@googlegroups.com
Prastik Gyawali started work on Task JENKINS-57903
 
Change By: Prastik Gyawali
Status: Open In Progress

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 7, 2019, 9:36:01 PM6/7/19
to jenkinsc...@googlegroups.com
Change By: Prastik Gyawali
Status: In Progress Review

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 8, 2019, 9:44:01 AM6/8/19
to jenkinsc...@googlegroups.com
Change By: Prastik Gyawali
Status: In Review Resolved
Resolution: Fixed

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 9, 2019, 1:03:02 PM6/9/19
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Task JENKINS-57903
 
Re: New PromotionProcess,PromotionCondition and PromotionConditionDescriptor classes for the plugin.

The ticket is marked as resolved, but the code has been neither merged nor submitted against right location for starters

jnz@topdanmark.dk (JIRA)

unread,
Jun 10, 2019, 8:38:02 AM6/10/19
to jenkinsc...@googlegroups.com
Jon Brohauge started work on Task JENKINS-57903
 
Change By: Jon Brohauge
Status: Reopened In Progress

jnz@topdanmark.dk (JIRA)

unread,
Jun 10, 2019, 8:38:02 AM6/10/19
to jenkinsc...@googlegroups.com
Jon Brohauge reopened an issue
 

Reopening issue due to missing link to PR
Change By: Jon Brohauge
Resolution: Fixed
Status: Resolved Reopened

jnz@topdanmark.dk (JIRA)

unread,
Jun 10, 2019, 8:38:03 AM6/10/19
to jenkinsc...@googlegroups.com
Reopening issue due to missing link to PR


Status set to _In Progress_

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 12, 2019, 6:46:02 AM6/12/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Change By: Oleg Nenashev
Before implementing the promotion-conditions(Self and Manual Conditions), it seems necessary to build new abstract/classes for the following existing classes.
* PromotionProcess
* PromotionCondition
* PromotionConditionDescriptor


For readability ease all these classes are being added by the word "Pipeline" as their prefix.

Three new analogous classes are being made retaining some of the original functions and will timely be updated as other classes start depending on them.


Acceptance criteria:
* The classes are created, and they can be used in further APIs. Ther eis is no user-facing feature for now
* The classes are marked as Restricted so that they not a part of API. It will change eventually
* There is basic test automation that these classes really work

 

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 13, 2019, 6:27:02 AM6/13/19
to jenkinsc...@googlegroups.com
Prastik Gyawali updated an issue
Change By: Prastik Gyawali
Before implementing the promotion-conditions(Self and Manual Conditions), it seems necessary to build new abstract/classes for the following existing classes.
* PromotionProcess
* PromotionCondition
* PromotionConditionDescriptor

For readability ease all these classes are being added by the word "Pipeline" as their prefix.

Three new analogous classes are being made retaining some of the original functions and will timely be updated as other classes start depending on them.

Acceptance criteria:
* The classes are created, and they can be used in further APIs. Ther eis There is is no user-facing feature for now

* The classes are marked as Restricted so that they not a part of API. It will change eventually
* There is basic test automation that these classes really work

 

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 20, 2019, 6:13:03 AM6/20/19
to jenkinsc...@googlegroups.com
Prastik Gyawali commented on Task JENKINS-57903
 
Re: New PromotionProcess,PromotionCondition and PromotionConditionDescriptor classes for the plugin.

Updates and changes in the task:

1) The same old PromotionDescriptor and PromotionCondition classes will instead be refactored.

2) For PromotionProcess a new class will be made as decided.

Relevant PR link:   

o.v.nenashev@gmail.com (JIRA)

unread,
Jul 2, 2019, 2:46:04 AM7/2/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Change By: Oleg Nenashev
Sprint: GSoC 2019. Coding Phase 1 , GSoC 2019. Coding Phase 2

o.v.nenashev@gmail.com (JIRA)

unread,
Jul 30, 2019, 3:29:16 AM7/30/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Sprint: GSoC 2019. Coding Phase 1, GSoC 2019. Coding Phase 2 , GSoC 2019. Coding Phase 3

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 16, 2019, 7:31:12 AM12/16/19
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Unassigned
 

Moving the issue to the JENKINS-36089 EPIC
Change By: Oleg Nenashev
Assignee: Prastik Gyawali
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 16, 2019, 7:35:05 AM12/16/19
to jenkinsc...@googlegroups.com
Oleg Nenashev stopped work on Task JENKINS-57903
 
Change By: Oleg Nenashev
Status: In Progress Open

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 16, 2019, 7:38:02 AM12/16/19
to jenkinsc...@googlegroups.com
Oleg Nenashev started work on Task JENKINS-57903
 
Change By: Oleg Nenashev
Status: Open In Progress

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 16, 2019, 7:38:02 AM12/16/19
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Oleg Nenashev
Change By: Oleg Nenashev
Assignee: Oleg Nenashev

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 16, 2019, 7:44:02 AM12/16/19
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Task JENKINS-57903
 
Re: New PromotionProcess,PromotionCondition and PromotionConditionDescriptor classes for the plugin.

Some code from Prastik Gyawali which could be reused:

  1.  https://github.com/jenkinsci/promoted-builds-plugin/pull/137/commits/9c51d9e14d021769b4f38a80f0b08f65637cff62
  2. https://github.com/jenkinsci/promoted-builds-plugin/pull/137/commits/d1ce53de6aa5622899b21768cca4e813c0fab024
  3. https://github.com/jenkinsci/promoted-builds-plugin/pull/137/commits/8aa5cec8c4feada2e5d14e6a8eaab66dc8c75cca
  4. https://github.com/jenkinsci/promoted-builds-plugin/pull/137/commits/4fa0b38bf7dc5dc832ede16b522fc896d970ee62

Some of this code can be retrieved from commits though it might be easier to just rewrite the code.

https://github.com/jenkinsci/promoted-builds-plugin/pull/131 will be closed as discussed above

 

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 25, 2019, 3:33:02 PM12/25/19
to jenkinsc...@googlegroups.com

I tried moving PromotionCondition to the draft API plugin, and it will impose binary compatibility issues due to explicit dependency on the PromotionProcess. Moving PromotionProcess to the API plugin would also require moving the Promotion and several other classes to the API plugin. Will experiment with renaming classes

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 27, 2019, 9:47:02 AM12/27/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Before implementing the promotion-conditions(Self and Manual Conditions), it seems necessary to build new abstract/classes for the following existing classes.
* PromotionProcess
*
PromotionCondition

* PromotionConditionDescriptor

For readability ease all these classes are being added by the word "Pipeline" as their prefix.

Three new analogous classes are being made retaining some of the original functions and will timely be updated as other classes start depending on them.

Acceptance criteria:
* The classes are created, and they can be used in further APIs. There is is no user-facing feature for now

* The classes are marked as Restricted so that they not a part of API. It will change eventually
* There is basic test automation that these classes really work

 
Reply all
Reply to author
Forward
0 new messages