[JIRA] (JENKINS-61745) Scan multibranch with date range or dop '@now'

9 views
Skip to first unread message

kwirth@perforce.com (JIRA)

unread,
Mar 30, 2020, 11:54:02 AM3/30/20
to jenkinsc...@googlegroups.com
Karl Wirth created an issue
 
Jenkins / Improvement JENKINS-61745
Scan multibranch with date range or dop '@now'
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: p4-plugin
Created: 2020-03-30 15:53
Environment: p4-plugin 1.10.9
Priority: Blocker Blocker
Reporter: Karl Wirth

When scanning for changes in multibranch pipelines we use p4 changes -m1 //Path/...@now. This is triggering a similar resource behavior to:

JENKINS-57870

For example with a big dataset in the multibranch scan log we see:

p4 changes -m1 //Path/branch/...@now
Request too large (over 500000); see 'p4 help maxresults'.
ERROR: [Mon Mar 30 13:07:05 CEST 2020] Could not fetch branches from source d5fe37f7-6c40-4111-af23-d4f539fec120
com.perforce.p4java.exception.RequestException: Request too large (over 500000); see 'p4 help maxresults'.

When checking this at the command line we see that limiting the query or dropping '@now' works:

$ p4 changes -m1 //path/branch/...@now
Request too large (over 500000); see 'p4 help maxresults'.$ p4 changes -m1 //path/branch/...@2020/03/30
Request too large (over 500000); see 'p4 help maxresults'.$ p4 changes -m1 //path/branch/...
Change 62552 on 2020/03/30 by user@PC1 'CL Description'$ p4 changes -m1 //path/branch/...@52552,62552
Change 62552 on 2020/03/30 by user@PC1 'CL Description'

Would be great if we could either drop the usage of '@now' or restrict to the last n changes.

 

 
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

kwirth@perforce.com (JIRA)

unread,
Mar 30, 2020, 11:56:03 AM3/30/20
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
Change By: Karl Wirth
Labels: P4_VERIFY

kwirth@perforce.com (JIRA)

unread,
Mar 30, 2020, 11:56:11 AM3/30/20
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
Change By: Karl Wirth
Environment: p4-plugin 1. 10. 1. 9

pallen@perforce.com (JIRA)

unread,
Mar 31, 2020, 4:10:03 AM3/31/20
to jenkinsc...@googlegroups.com
Paul Allen commented on Improvement JENKINS-61745
 
Re: Scan multibranch with date range or dop '@now'

I doubt the p4d is scanning the wrong way (the -m1 flag should be minimal load).  The Build user should not have MaxResults set; perhaps MaxLockTime would be more appropriate or run off a replica to minimise load.

Notes: Possibly apply ConnectionHelper::getHeadLimit() to AbstractP4ScmSource::findLatestChange(...)

pallen@perforce.com (JIRA)

unread,
Apr 1, 2020, 6:20:05 AM4/1/20
to jenkinsc...@googlegroups.com

pallen@perforce.com (JIRA)

unread,
Apr 1, 2020, 6:32:02 AM4/1/20
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages