[JIRA] (JENKINS-57919) Naming Turkish localization plugin

Naming Turkish localization plugin

Issue Type:	Improvement
Assignee:	Daniel Beck
Components:	localization-support-plugin
Created:	2019-06-08 17:47
Labels:	localization
Priority:	Minor
Reporter:	Mustafa Ulu

What should be the artifact id of a Turkish localization plugin?

According to JEP-216, the artifact id must include the country code (localization-[language code]-[country code]-plugin), but Turkish localization files inside Jenkins do not contain country code (Messages_tr.properties).

Should I name the artifact as "localization-tr-tr-plugin" and rename all files to "Messages_tr_TR.properties" or is the name "localization-tr-plugin" enough?

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

dbeck@cloudbees.com (JIRA)

unread,

Jun 8, 2019, 6:05:02 PM6/8/19

to jenkinsc...@googlegroups.com

Daniel Beck commented on

TLDR: Use localization-tr.

JEP-216 is wrong in this regard, and should be changed.

First, the -plugin suffix goes against regular plugin naming convention. Even localization-zh-cn does not follow this rule.
Secondly, JEP-216 was authored by a contributor from China, where the country code is essential to distinguish Simplified Chinese (China) from Traditional Chinese (Taiwan), so I guess stating that country code is required, even if not useful for the majority of languages, is just a simple oversight.

Thanks for checking!

dbeck@cloudbees.com (JIRA)

unread,

Jun 8, 2019, 6:05:02 PM6/8/19

to jenkinsc...@googlegroups.com

Daniel Beck closed an issue as Not A Defect

Jenkins /

Naming Turkish localization plugin

Change By:	Daniel Beck
Status:	Open Closed
Resolution:	Not A Defect

dbeck@cloudbees.com (JIRA)

unread,

Jun 8, 2019, 6:07:06 PM6/8/19

to jenkinsc...@googlegroups.com

Daniel Beck commented on

(Obviously, if there is a "China" kind of situation for Turkish that I might be unaware of, this changes. But I would still recommend e.g. localization-pt for Portuguese, and localization-pt-br for Brazilian Portuguese, if those were maintained in separate plugins. I expect even if there's a notable variant of Turkish, that "Turkey Turkish" would be the "default" here)

mustafaulu.net@gmail.com (JIRA)

unread,

Jun 9, 2019, 6:23:02 AM6/9/19

to jenkinsc...@googlegroups.com

Mustafa Ulu commented on

Thanks for your time. I will use following names:

Repository: localization-tr-plugin.git

Artifact: localization-tr.hpi

mustafaulu.net@gmail.com (JIRA)

unread,

Jun 9, 2019, 6:33:03 AM6/9/19

to jenkinsc...@googlegroups.com

Mustafa Ulu updated an issue

Jenkins /

Naming Turkish localization plugin

Change By:	Mustafa Ulu
URL:	https://github.com/mustafau/localization-tr- tr- plugin

mustafaulu.net@gmail.com (JIRA)

unread,

Jun 9, 2019, 10:50:01 AM6/9/19

to jenkinsc...@googlegroups.com

Mustafa Ulu commented on

I have created a hosting request: https://issues.jenkins-ci.org/browse/HOSTING-783

linuxsuren@gmail.com (JIRA)

unread,

Jun 9, 2019, 10:26:02 PM6/9/19

to jenkinsc...@googlegroups.com

Rick commented on

First, the -plugin suffix goes against regular plugin naming convention. Even localization-zh-cn does not follow this rule.

I'm not sure I understand this point. You mean the code repo name should be jenkinsci/localization-zh-cn?

And thanks to Daniel Beck for the explanation.

dbeck@cloudbees.com (JIRA)

unread,

Jun 9, 2019, 11:59:02 PM6/9/19

to jenkinsc...@googlegroups.com

Daniel Beck commented on

I'm not sure I understand this point. You mean the code repo name should be jenkinsci/localization-zh-cn?

The repo is $artifactId-plugin and therefore derived from the artifact ID / plugin name. If you are talking about the repo name in https://github.com/jenkinsci/jep/tree/master/jep/216#plugin-naming rather than plugin name, that is unclear.