[JIRA] (JENKINS-62105) github-plugin doesn't properly handle API rate limit exhaustion

[chad@irisonboard.com (JIRA)]

Chad Feller updated an issue

Jenkins / JENKINS-62105 github-plugin doesn't properly handle API rate limit exhaustion Change By: Chad Feller Summary: github-plugin doesn't properly handle API ( rate limit ) exhaustion Add Comment

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)

[chad@irisonboard.com (JIRA)]

Chad Feller updated an issue

Jenkins / JENKINS-62105 github-plugin doesn't properly handle API rate limit exhaustion Change By: Chad Feller

In a situation where Github API calls are exhausted (rate limited), Github plugin will claim to have set a git commit status when it was unable to.  In such a scenario, using "Set GitHub commit status (universal)" as Post build action, a status line such as this will be printed out to the console of the affected build: {code:java} [Set GitHub commit status (universal)] SUCCESS on repos [] (sha:bfc5a2c) with context: <project_name_redacted> {code} On a build where the API calls are not exhausted, it should look more like this.  {code:java} [Set GitHub commit status (universal)] SUCCESS on repos [GHRepository@1234abc [<should>, <be>, <lots>, <of>, <data>, <here>]] . (sha:bfc5a2c) with context: <project_name_redacted> {code} The issue appears to be that this line: [https://github.com/jenkinsci/github-plugin/blob/51dc96b336818b6df56bb85ec91fa384fe55ab86/src/main/java/org/jenkinsci/plugins/github/status/GitHubCommitStatusSetter.java#L136] doesn't care if it gets an empty list back. Somewhere we should raise an error rather than silently failing due to API rate limiting.

Add Comment