[JIRA] (JENKINS-48791) Cannot open Job configuration

I have come across the same problem today. It turns out that you can create a tool entry on the Global Tools Configuration page but Tool Environment plugin does not have a null check for it in toolsByVar() method.

 
                                                                private static Map<String,ToolInstallation> toolsByVar() {
    Map<String,ToolInstallation> r = new TreeMap<String,ToolInstallation>();
    for (ToolDescriptor<?> desc : ToolInstallation.all()) {
        for (ToolInstallation inst : desc.getInstallations()) {
            r.put(inst.getName().replaceAll("[^a-zA-Z0-9_]+", "_").toUpperCase(Locale.ENGLISH) + "_HOME", inst);
        }
    }
    return r;
}
 
                                                            

inst.getName() needs to be checked for null

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

jenkinsci@kundrik.com (JIRA)

unread,

Aug 30, 2019, 6:58:03 AM8/30/19

to jenkinsc...@googlegroups.com

Slavomir Kundrik started work on

Change By:	Slavomir Kundrik
Status:	Open In Progress

jenkinsci@kundrik.com (JIRA)

unread,

Aug 30, 2019, 6:58:03 AM8/30/19

to jenkinsc...@googlegroups.com

Slavomir Kundrik assigned an issue to Slavomir Kundrik

Jenkins /

Cannot open Job configuration

Change By:	Slavomir Kundrik
Assignee:	Slavomir Kundrik

jenkinsci@kundrik.com (JIRA)

unread,

Aug 30, 2019, 7:00:01 AM8/30/19

to jenkinsc...@googlegroups.com

Slavomir Kundrik commented on

Jesse Glick I have submitted a PR for this

jglick@cloudbees.com (JIRA)

unread,

Aug 30, 2019, 7:51:02 AM8/30/19

to jenkinsc...@googlegroups.com

Jesse Glick commented on

Not sure why I am being mentioned. I do not have anything to do with this plugin.

jenkinsci@kundrik.com (JIRA)

unread,

Aug 30, 2019, 8:54:02 AM8/30/19

to jenkinsc...@googlegroups.com

Slavomir Kundrik commented on