[JIRA] (JENKINS-60467) The file field on FileCredentialsImpl of class FileItem is not describable

19 views
Skip to first unread message

josephp90@gmail.com (JIRA)

unread,
Dec 12, 2019, 6:13:01 PM12/12/19
to jenkinsc...@googlegroups.com
Joseph Petersen updated an issue
 
Jenkins / Bug JENKINS-60467
The file field on FileCredentialsImpl of class FileItem is not describable
Change By: Joseph Petersen
Summary: The file field on FileCredentialsImpl of class FileItem is not describable
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Dec 13, 2019, 10:11:03 AM12/13/19
to jenkinsc...@googlegroups.com
Jesse Glick commented on Bug JENKINS-60467
 
Re: The file field on FileCredentialsImpl of class FileItem is not describable

FileCredentialsImpl is weird. Definitely not a generally supported usage of @DataBoundConstructor. You cannot and should not attempt to export a FileItem; it is just there to handle browser file uploads. From the perspective of JCasC, ignore the file parameter and use only fileName + secretBytes (the things you actually have getters for anyway).

You may need to be adding SecretBytes support to JCasC for the first time. Created by Stephen Connolly. AFAIK used only by FileCredentialsImpl and CertificateCredentialsImpl.

jglick@cloudbees.com (JIRA)

unread,
Dec 13, 2019, 10:12:03 AM12/13/19
to jenkinsc...@googlegroups.com

jglick@cloudbees.com (JIRA)

unread,
Dec 13, 2019, 10:12:04 AM12/13/19
to jenkinsc...@googlegroups.com
Jesse Glick updated an issue
Change By: Jesse Glick
Component/s: configuration-as-code-plugin

jglick@cloudbees.com (JIRA)

unread,
Dec 13, 2019, 10:13:02 AM12/13/19
to jenkinsc...@googlegroups.com
 
Re: The file field on FileCredentialsImpl of class FileItem is not describable

To be clear, I do not believe any patch to plain-credentials is possible, at least without a rewrite of file uploads in Stapler. configuration-as-code is just going to have to deal with what is there.

josephp90@gmail.com (JIRA)

unread,
Mar 7, 2020, 1:10:18 AM3/7/20
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Joseph Petersen
 
Change By: Joseph Petersen
Assignee: Joseph Petersen
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

josephp90@gmail.com (JIRA)

unread,
Mar 7, 2020, 1:25:05 AM3/7/20
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Unassigned

timjacomb1@gmail.com (JIRA)

unread,
Mar 7, 2020, 5:30:03 AM3/7/20
to jenkinsc...@googlegroups.com

timjacomb1@gmail.com (JIRA)

unread,
Mar 7, 2020, 5:30:04 AM3/7/20
to jenkinsc...@googlegroups.com

timjacomb1@gmail.com (JIRA)

unread,
Mar 7, 2020, 5:31:04 AM3/7/20
to jenkinsc...@googlegroups.com
Tim Jacomb started work on Bug JENKINS-60467
 
Change By: Tim Jacomb
Status: Open In Progress

timjacomb1@gmail.com (JIRA)

unread,
Mar 7, 2020, 5:31:05 AM3/7/20
to jenkinsc...@googlegroups.com

timjacomb1@gmail.com (JIRA)

unread,
Mar 7, 2020, 5:31:05 AM3/7/20
to jenkinsc...@googlegroups.com
Change By: Tim Jacomb
Status: In Review Resolved
Resolution: Fixed
Released As: 2.3.3

timjacomb1@gmail.com (JIRA)

unread,
Mar 7, 2020, 5:31:05 AM3/7/20
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages