[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a stage with an agent

2 views
Skip to first unread message

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 19, 2019, 5:53:02 PM3/19/19
to jenkinsc...@googlegroups.com
Devin Nusbaum updated an issue
 
Jenkins / Improvement JENKINS-56544
failFast option for parallel stages sets build status to ABORTED when failure is inside of a stage with an agent
Change By: Devin Nusbaum
Summary: failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage with an agent
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 19, 2019, 5:54:02 PM3/19/19
to jenkinsc...@googlegroups.com

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 19, 2019, 5:54:06 PM3/19/19
to jenkinsc...@googlegroups.com
Devin Nusbaum updated an issue
h3. Symptom

With a Pipeline using parallel stages with {{failFast true}} enabled, when a
nested stage with an agent fails, the final build result is showing as {{ABORTED}} instead of {{FAILURE}}

A similar bug was recently fixed JENKINS-55459 which corrected the build status result when using non-nested parallel stages with {{failFast true}} enabled, but it seems it did not catch the case where a nested stage inside of one of the parallel stages fails.
h3. Evidence

The fix for JENKINS-55459 was delivered under version 1.3.5 of the [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition], I am testing version 1.3.6.

I started up a brand new Jenkins LTS 2.150.3 instance, with the 'recommended' plugins, including [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition] version 1.3.6

I ran the testcase inside of JENKINS-55459 and the build status is correctly marked as failed, so the fix from JENKINS-55459 was correct.

When I run the attached [^Jenkinsfile] , the build still shows as {{ABORTED}}:

!test.png!
{code}
...
ERROR: script returned exit code 1
Finished: ABORTED
{code}
Here is the full log: [^log]

I expected the build status to be marked as {{FAILURE}}, not {{ABORTED}}.
h3. Hypothesis

I believe the fix from JENKINS-55459 worked, but does not account for failures inside of
nested stages with agents within the parallel stages.

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 19, 2019, 5:55:03 PM3/19/19
to jenkinsc...@googlegroups.com
Devin Nusbaum commented on Improvement JENKINS-56544
 
Re: failFast option for parallel stages sets build status to ABORTED when failure is inside of a stage with an agent

Filed https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/322 which I think should fix the problem and updated the ticket title/description with what seems like crux of the issue - the fix in JENKINS-55459 didn't work for any stage with an agent.

andrew.bayer@gmail.com (JIRA)

unread,
Mar 20, 2019, 11:24:03 AM3/20/19
to jenkinsc...@googlegroups.com
Andrew Bayer updated Improvement JENKINS-56544
 

Merged, releasing as 1.3.7 right now.

Change By: Andrew Bayer
Status: In Review Fixed but Unreleased
Resolution: Fixed

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 20, 2019, 1:48:02 PM3/20/19
to jenkinsc...@googlegroups.com

ray.kivisto@gmail.com (JIRA)

unread,
Mar 21, 2019, 5:02:02 PM3/21/19
to jenkinsc...@googlegroups.com

bitwiseman@gmail.com (JIRA)

unread,
Oct 22, 2019, 11:24:20 PM10/22/19
to jenkinsc...@googlegroups.com
Liam Newman closed an issue as Fixed
 

Bulk closing resolved issues.

Change By: Liam Newman
Status: Resolved Closed
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages