[JIRA] (JENKINS-48803) Powershell under linux have changed the command to pwsh

onodera@mail.ru (JIRA)

unread,

Nov 27, 2018, 7:03:01 AM11/27/18

to jenkinsc...@googlegroups.com

Alexey Marin commented on

JENKINS-48803

Re: Powershell under linux have changed the command to pwsh

Discussing in this PR shows it's dangerous to use "isUnix()" to choose the binary. Plus, there are Windows Server distributions that only have pwsh.exe. What if the plugin actually exposed two commands?

 
                                                                powershell 'gci .' //launches Windows PowerShell
pwsh 'gci .' //launches PowerShell Core

The only drawback I see is you won't be able to have a truly cross-platform pipeline unless you install PowerShell Core on all your Windows agents. Alternative solution: keep only one command and:

if the system is detected as Unix, use `which pwsh` and then `which powershell` to check for the correct binary
if the system is detected as Windows, use `where.exe pwsh` and then `where.exe powershell` to check for the correct binary

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

onodera@mail.ru (JIRA)

unread,

Nov 27, 2018, 7:03:01 AM11/27/18

to jenkinsc...@googlegroups.com

Alexey Marin edited a comment on

JENKINS-48803

Re: Powershell under linux have changed the command to pwsh

Discussing in this PR shows it's dangerous to use "isUnix()" to choose the binary. Plus, there are Windows Server distributions that only have pwsh.exe. What if the plugin actually exposed two commands?

{code:java}

powershell 'gci .' //launches Windows PowerShell
pwsh 'gci .' //launches PowerShell Core

{code}

The only drawback I see is you won't be able to have a truly cross-platform pipeline unless you install PowerShell Core on all your Windows agents. Alternative solution: keep only one command and:

* if the system is detected as Unix, use `which pwsh` and then `which powershell` to check for the correct binary
* if the system is detected as Windows, use `where.exe pwsh .exe ` and then `where.exe powershell .exe ` to check for the correct binary

Add Comment

josephp90@gmail.com (JIRA)

unread,

Nov 1, 2019, 12:55:03 PM11/1/19

to jenkinsc...@googlegroups.com

Joseph Petersen resolved as Fixed

Released as 2.35

Jenkins /

JENKINS-48803

Powershell under linux have changed the command to pwsh

Change By:	Joseph Petersen
Status:	Open Resolved
Assignee:	Liam Leane Joseph Petersen
Resolution:	Fixed
Released As:	https://github.com/jenkinsci/workflow-durable-task-step-plugin/blob/workflow-durable-task-step-2.35/CHANGELOG.md#235