[JIRA] (JENKINS-58084) Vetoable version of GraphListener

8 views
Skip to first unread message

jglick@cloudbees.com (JIRA)

unread,
Jun 18, 2019, 2:09:02 PM6/18/19
to jenkinsc...@googlegroups.com
Jesse Glick created an issue
 
Jenkins / Improvement JENKINS-58084
Vetoable version of GraphListener
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: workflow-api-plugin, workflow-cps-plugin
Created: 2019-06-18 18:08
Labels: api
Priority: Minor Minor
Reporter: Jesse Glick

GraphListener gives you access to a FlowNode but not a StepContext which sometimes has richer information. It also provides no straightforward way to block the execution of a step before it begins (though you can abort the build soon afterward). For some purposes it would be nice to have something like

public interface StepListener extends ExtensionPoint {
  void newStep(Step step, StepContext context) throws Exception;
}

The natural place to call this would be right before Step.start, at which point all the abovementioned information is available, and any Exception can just be handled in onFailure just like a synchronous error from start would.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

andrew.bayer@gmail.com (JIRA)

unread,
Jun 25, 2019, 3:07:02 PM6/25/19
to jenkinsc...@googlegroups.com
Andrew Bayer started work on Improvement JENKINS-58084
 
Change By: Andrew Bayer
Status: Open In Progress

andrew.bayer@gmail.com (JIRA)

unread,
Jun 25, 2019, 3:07:02 PM6/25/19
to jenkinsc...@googlegroups.com
Andrew Bayer assigned an issue to Andrew Bayer
Change By: Andrew Bayer
Assignee: Andrew Bayer

andrew.bayer@gmail.com (JIRA)

unread,
Jun 26, 2019, 8:46:03 AM6/26/19
to jenkinsc...@googlegroups.com
Andrew Bayer commented on Improvement JENKINS-58084
 
Re: Vetoable version of GraphListener

Super-preliminary PRs up for workflow-api and workflow-cps.

kshultz@cloudbees.com (JIRA)

unread,
Nov 13, 2019, 12:07:03 PM11/13/19
to jenkinsc...@googlegroups.com
Karl Shultz resolved as Done
 

This has been done and merged, thanks Andrew!

Merged PRs:

Change By: Karl Shultz
Status: In Progress Resolved
Resolution: Done
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages