[JIRA] (JENKINS-56323) The new issues are 'new' compared to only one particular build for the project, the new issues section would be so much more useful if there was an option to compare against the last build

4 views
Skip to first unread message

juliehirani@hotmail.com (JIRA)

unread,
Feb 28, 2019, 7:14:02 AM2/28/19
to jenkinsc...@googlegroups.com
Julie Shamji created an issue
 
Jenkins / Improvement JENKINS-56323
The new issues are 'new' compared to only one particular build for the project, the new issues section would be so much more useful if there was an option to compare against the last build
Issue Type: Improvement Improvement
Assignee: Ulli Hafner
Components: warnings-ng-plugin
Created: 2019-02-28 12:13
Priority: Minor Minor
Reporter: Julie Shamji

The new issues are 'new' compared to only one particular build for the project, the new issues section would be so much more useful if there was an option to compare against the previous/preceding build.

This would allow a project to monitored for new and fixed issues from build to build for the same project.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,
Feb 28, 2019, 12:32:02 PM2/28/19
to jenkinsc...@googlegroups.com

juliehirani@hotmail.com (JIRA)

unread,
Feb 28, 2019, 12:55:02 PM2/28/19
to jenkinsc...@googlegroups.com

ullrich.hafner@gmail.com (JIRA)

unread,
Feb 28, 2019, 2:59:02 PM2/28/19
to jenkinsc...@googlegroups.com

No, this is not correct: if you set ignoreQualityGate: true then always the previous build is used to compute new warnings. This has nothing to do with the quality gate itself. You still can fail a build based on the number of new warnings.

juliehirani@hotmail.com (JIRA)

unread,
Mar 1, 2019, 5:55:02 AM3/1/19
to jenkinsc...@googlegroups.com

Can the description of this option be updated to make this clear please? The current description does not suggest that the reference build is different when set to true.

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 1, 2019, 8:07:02 AM3/1/19
to jenkinsc...@googlegroups.com

juliehirani@hotmail.com (JIRA)

unread,
Jul 26, 2019, 6:15:02 AM7/26/19
to jenkinsc...@googlegroups.com

I have set ignoreQualityGate to true and for the past two builds I am getting the same issues highlighted as new as the files have not been changed.

Below are 3 examples of over 80 of these.

The following may be important:

  • The reference build shown against all these build is build #276 even though I have ignoreQualityGate true.
  • Build #287 and a number of builds before this had projects failed to build but quality statistics were generated as I am using the -fn option. Should I be using the run always option instead?
  • One of the changes in build #288 is a new version of checkstyle.

Build #288 - I expected these failures as this project had failed to build so there were no statistics produced so these then look 'fixed'.

ExportMsDocumentServiceImpl.java:130 com.unisys.holmes2.h2ng.export.business.impl Indentation IndentationCheck Normal 1
ExportMsDocumentServiceImpl.java:131 com.unisys.holmes2.h2ng.export.business.impl Indentation IndentationCheck Normal 1
ExportMsDocumentServiceImpl.java:132 com.unisys.holmes2.h2ng.export.business.impl Indentation IndentationCheck Normal 1

Build #289 - I did not expect this again. Which build was this evaluated against? The last build which failed or the last successful build?

ExportMsDocumentServiceImpl.java:130 com.unisys.holmes2.h2ng.export.business.impl Indentation IndentationCheck Normal 1
ExportMsDocumentServiceImpl.java:131 com.unisys.holmes2.h2ng.export.business.impl Indentation IndentationCheck Normal 1
ExportMsDocumentServiceImpl.java:132 com.unisys.holmes2.h2ng.export.business.impl Indentation IndentationCheck Normal 1

 

On the description of the option, what about the following:

'If checked, then the result of the quality gate is ignored when selecting a reference build and will evaluate the issue age and new/existing against the previous build instead of the reference build. This option is disabled by default so a failing quality gate will be passed from build to build until the original reason for the failure has been resolved.'

juliehirani@hotmail.com (JIRA)

unread,
Jul 26, 2019, 7:39:02 AM7/26/19
to jenkinsc...@googlegroups.com

If the plugin compares against the last successful/unstable build, the following is more clear:

'If checked, then the result of the quality gate is ignored when selecting a reference build and will evaluate the issue age and new/existing against the last successful or unstable build instead of the reference build. This option is disabled by default so a failing quality gate will be passed from build to build until the original reason for the failure has been resolved.'

Reply all
Reply to author
Forward
0 new messages