[JIRA] (JENKINS-62004) Parameterized Remote Trigger expects case-sensitive http headers

32 views
Skip to first unread message

eschulz@cisco.com (JIRA)

unread,
Apr 22, 2020, 2:00:04 AM4/22/20
to jenkinsc...@googlegroups.com
Eric Schulz created an issue
 
Jenkins / Bug JENKINS-62004
Parameterized Remote Trigger expects case-sensitive http headers
Issue Type: Bug Bug
Assignee: KaiHsiang Chang
Components: parameterized-remote-trigger-plugin
Created: 2020-04-22 05:59
Environment: Remote jenkins running 2.164.32.0.1-fixed
Priority: Minor Minor
Reporter: Eric Schulz

For remote jekins that provides all lower-case HTTP headers, the parameterized remote trigger will fail with error such as

ERROR: Remote build failed with 'AbortException' for the following reason: 'Error triggering the remote job. The header of the response has an unexpected format:

{date=[Tue, 21 Apr 2020 02:26:47 GMT], null=[HTTP/1.1 201 Created], server=[envoy], content-length=[0], x-envoy-upstream-service-time=[15], x-content-type-options=[nosniff], location=[http://example.com/jenkins/myjenkins/queue/item/4848912/]}'.

It seems the plugin is looking for "Location" but only "location" is provided.

https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/68 has some test cases demonstrating the issue and a possible solution.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

steven.christenson@CISCO.COM (JIRA)

unread,
Apr 22, 2020, 12:36:03 PM4/22/20
to jenkinsc...@googlegroups.com
Steven Christenson commented on Bug JENKINS-62004
 
Re: Parameterized Remote Trigger expects case-sensitive http headers

    3.2. Header Fields

    Each header field consists of a *case-insensitive* field name followed
    by a colon (":"), optional leading whitespace, the field value, and
    optional trailing whitespace.

https://tools.ietf.org/html/rfc7230#appendix-A.2

Looks like most things are expected to be case-insensitive... So if the receiving Jenkins doesn't work ... it is in error.
Of course the wonderful thing about standards is that everyone can have their own!

To be clear, this isn't so much a problem with the plugin it is Jenkins 2.164.32.0.1-fixed
That is failing to accept what should be a case-insensitive value.

steven.christenson@CISCO.COM (JIRA)

unread,
Apr 22, 2020, 12:38:02 PM4/22/20
to jenkinsc...@googlegroups.com
Steven Christenson edited a comment on Bug JENKINS-62004
    3.2. Header Fields

    Each header field consists of a **case-insensitive** field name followed

    by a colon (":"), optional leading whitespace, the field value, and
    optional trailing whitespace.

[https://tools.ietf.org/html/rfc7230#appendix-A.2]

Looks like most things are expected to be case-insensitive... So if the receiving Jenkins doesn't work ... it is in error.
Of course the wonderful thing about standards is that everyone can have their own!

To be clear, this isn't so much a problem with the plugin it is *Jenkins 2.164.32.0.1-fixed*

That is failing to accept what should be a case-insensitive value.


The version of the invoker in this case is: Parameterized-Remote-Trigger:3.1.2

steven.christenson@CISCO.COM (JIRA)

unread,
Apr 22, 2020, 1:05:03 PM4/22/20
to jenkinsc...@googlegroups.com

steven.christenson@CISCO.COM (JIRA)

unread,
Apr 22, 2020, 1:05:04 PM4/22/20
to jenkinsc...@googlegroups.com
Steven Christenson edited a comment on Bug JENKINS-62004
    3.2. Header Fields

    Each header field consists of a **case-insensitive** field name followed
    by a colon (":"), optional leading whitespace, the field value, and
    optional trailing whitespace.

[https://tools.ietf.org/html/rfc7230#appendix-A.2]

Looks like most things are expected to be case-insensitive...
So if the receiving Jenkins doesn't work ... it is in error.  
Of course the wonderful thing about standards is that everyone can have their own!

The version of the invoker in this case is: Parameterized-Remote-Trigger:3.1.2

cash924n@gmail.com (JIRA)

unread,
Apr 23, 2020, 11:23:03 AM4/23/20
to jenkinsc...@googlegroups.com
KaiHsiang Chang updated Bug JENKINS-62004
 

Reviewed PR and merged.

Change By: KaiHsiang Chang
Status: Open Fixed but Unreleased
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages