[JIRA] (JENKINS-58650) Support proxy for App Center uploads

b5189271@urhen.com (JIRA)

unread,

Jul 24, 2019, 4:28:02 PM7/24/19

to jenkinsc...@googlegroups.com

Jenk O' Lino created an issue

Jenkins /

JENKINS-58650

Support proxy for App Center uploads

Issue Type:	Improvement
Assignee:	Mez Pahlan
Components:	appcenter-plugin
Created:	2019-07-24 20:27
Priority:	Major
Reporter:	Jenk O' Lino

At the moment the tests are rather simple and do not protect against mandatory constructor parameters not being able to be added via the UI. We also do not have any pipeline tests.

Acceptance criteria:

1. An example pipeline tests to build upon.
2. An example freestyle configuration tests.

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

b5189271@urhen.com (JIRA)

unread,

Jul 24, 2019, 4:29:01 PM7/24/19

to jenkinsc...@googlegroups.com

Jenk O' Lino updated an issue

Jenkins /

JENKINS-58650

Support proxy for App Center uploads

Change By:	Jenk O' Lino

At the moment the tests are rather simple and do The current configuration of OkHttp client in appcenter-plugin does not protect against mandatory constructor parameters take Jenkins proxy configuration into account, not being able does it allow to be added via the UI specify proxy settings manually . We also do not have any pipeline tests.

Acceptance criteria:

1. An example pipeline tests For every call to build upon App Center's API, Jenkins proxy settings should be used .

2. An example freestyle configuration tests.

Add Comment

b5189271@urhen.com (JIRA)

unread,

Jul 24, 2019, 4:36:01 PM7/24/19

to jenkinsc...@googlegroups.com

Jenk O' Lino commented on

JENKINS-58650

Re: Support proxy for App Center uploads

I started looking into how other plugins solved this with OkHttp. I think this is a good starting point: https://github.com/jenkinsci/octoperf-plugin/commit/59ec669bc48ffffda482d8efe2df667f7ded7ac2

Add Comment

mez.pahlan@gmail.com (JIRA)

unread,

Jul 24, 2019, 4:46:02 PM7/24/19

to jenkinsc...@googlegroups.com

Mez Pahlan commented on

JENKINS-58650

Re: Support proxy for App Center uploads

Hi Jenk O' Lino thanks for raising this. Definitely something to look into. To be honest I don't know the best way to go about this at the moment. We could take the view that proxy network configuration is out of scope of this plugin. It can be configured on the JVM for instance. However we could also take the view that we should make an effort to detect and use any proxy set in the Jenkins plugin configuration section.

I am torn on that at the moment. I'll ask a question to the dev mailing list later and see what the consensus is. But in the mean time your link is a good starting point to explore.

Thanks.