[JIRA] (JENKINS-47107) p4cleanup/cleanup ignores 'true/false' flag

15 views
Skip to first unread message

kwirth@perforce.com (JIRA)

unread,
Jan 29, 2019, 11:35:02 AM1/29/19
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
 
Jenkins / Improvement JENKINS-47107
p4cleanup/cleanup ignores 'true/false' flag
Change By: Karl Wirth
Labels: P4_B
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

kwirth@perforce.com (JIRA)

unread,
Jan 29, 2019, 11:35:02 AM1/29/19
to jenkinsc...@googlegroups.com
Karl Wirth commented on Improvement JENKINS-47107
 
Re: p4cleanup/cleanup ignores 'true/false' flag

Suggest this is fixed or 'true/false' is removed from 'cleanup' and documentation states this is a global setting (bubble text and docs). Upping to B to raise awareness.

pallen@perforce.com (JIRA)

unread,
Jun 4, 2019, 10:08:02 AM6/4/19
to jenkinsc...@googlegroups.com
Paul Allen assigned an issue to Kevin Williamson
Change By: Paul Allen
Assignee: Kevin Williamson

pallen@perforce.com (JIRA)

unread,
Jun 4, 2019, 10:39:03 AM6/4/19
to jenkinsc...@googlegroups.com
Paul Allen updated an issue
Change By: Paul Allen
Labels: P4_B P4_DOC

kwilliamson@perforce.com (JIRA)

unread,
Jun 19, 2019, 5:20:02 AM6/19/19
to jenkinsc...@googlegroups.com
Kevin Williamson started work on Improvement JENKINS-47107
 
Change By: Kevin Williamson
Status: Open In Progress

kwirth@perforce.com (JIRA)

unread,
Jun 20, 2019, 5:04:02 AM6/20/19
to jenkinsc...@googlegroups.com

For clarity:

(1) Without any global options set and with 'cleanup' build step:

No cleanup attempted.

(2) With Global option 'Delete Perforce client' and with 'cleanup' build step:

P4 Task: remove client: jenkins-master-JENKINS-47107_-_Cleanup-8
... p4 client -d jenkins-master-JENKINS-47107_-_Cleanup-8 -p4 client -d jenkins-master-JENKINS-47107_-_Cleanup-8

Client jenkins-master-JENKINS-47107_-_Cleanup-8 deleted.

(3) With Global option 'Delete Workspace files' and with 'cleanup' build step: 

P4 Task: cleanup client: jenkins-master-JENKINS-47107_-_Cleanup-0
P4 Task: unsyncing client: jenkins-master-JENKINS-47107_-_Cleanup-0
P4 Task: syncing files at change: 0
... p4 sync -f -q /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...@0 -p4 sync -f -q /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...@0

(4) With Global options 'Delete Perforce client' and 'Delete Workspace files' 

P4 Task: cleanup client: jenkins-master-JENKINS-47107_-_Cleanup-9
P4 Task: unsyncing client: jenkins-master-JENKINS-47107_-_Cleanup-9
P4 Task: syncing files at change: 0
... p4 sync -f -q /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...@0 -p4 sync -f -q /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...@0
... totalFileSize 0
... totalFileCount 1
duration: (2ms)

... p4 client -o jenkins-master-JENKINS-47107_-_Cleanup-9 +... p4 revert /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/... -p4 revert /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...

/var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/... - file(s) not opened on this client.

P4 Task: remove client: jenkins-master-JENKINS-47107_-_Cleanup-9
... p4 client -d jenkins-master-JENKINS-47107_-_Cleanup-9 -p4 client -d jenkins-master-JENKINS-47107_-_Cleanup-9

Client jenkins-master-JENKINS-47107_-_Cleanup-9 deleted.

Also note that the 'cleanup' groovy step is valid without parameters.

 

kwirth@perforce.com (JIRA)

unread,
Jun 20, 2019, 5:31:02 AM6/20/19
to jenkinsc...@googlegroups.com
Karl Wirth edited a comment on Improvement JENKINS-47107
For clarity:

(1) Without any global options set and with 'cleanup' build step:
{code:java}
No cleanup attempted.
{code}

(2) With Global option 'Delete Perforce client' and with 'cleanup' build step:
{code:java}

P4 Task: remove client: jenkins-master-JENKINS-47107_-_Cleanup-8
... p4 client -d jenkins-master-JENKINS-47107_-_Cleanup-8 -p4 client -d jenkins-master-JENKINS-47107_-_Cleanup-8

Client jenkins-master-JENKINS-47107_-_Cleanup-8 deleted.
{code}

(3) With Global option 'Delete Workspace files' and with 'cleanup' build step: 
{code:java}

P4 Task: cleanup client: jenkins-master-JENKINS-47107_-_Cleanup-0
P4 Task: unsyncing client: jenkins-master-JENKINS-47107_-_Cleanup-0
P4 Task: syncing files at change: 0
... p4 sync -f -q /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...@0 -p4 sync -f -q /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...@0
{code}

(4) With Global options 'Delete Perforce client' and 'Delete Workspace files' 
{code:java}

P4 Task: cleanup client: jenkins-master-JENKINS-47107_-_Cleanup-9
P4 Task: unsyncing client: jenkins-master-JENKINS-47107_-_Cleanup-9
P4 Task: syncing files at change: 0
... p4 sync -f -q /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...@0 -p4 sync -f -q /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...@0
... totalFileSize 0
... totalFileCount 1
duration: (2ms)

... p4 client -o jenkins-master-JENKINS-47107_-_Cleanup-9 +... p4 revert /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/... -p4 revert /var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/...

/var/lib/jenkins/workspace/JENKINS-47107 - Cleanup/... - file(s) not opened on this client.

P4 Task: remove client: jenkins-master-JENKINS-47107_-_Cleanup-9
... p4 client -d jenkins-master-JENKINS-47107_-_Cleanup-9 -p4 client -d jenkins-master-JENKINS-47107_-_Cleanup-9

Client jenkins-master-JENKINS-47107_-_Cleanup-9 deleted.
{code}
 Also note that  

IMPORTANT NOTE: Groovy step "cleanup" without a paramater is not valid. Therefore if it is not used the 'cleanup' groovy step is valid without parameters function must be fixed to not take true/false .

 

kwilliamson@perforce.com (JIRA)

unread,
Jun 20, 2019, 7:22:02 AM6/20/19
to jenkinsc...@googlegroups.com
Change By: Kevin Williamson
Status: In Progress Review

kwilliamson@perforce.com (JIRA)

unread,
Jun 20, 2019, 7:22:02 AM6/20/19
to jenkinsc...@googlegroups.com
Kevin Williamson assigned an issue to Karl Wirth
Change By: Kevin Williamson
Assignee: Kevin Williamson Karl Wirth

kwilliamson@perforce.com (JIRA)

unread,
Jul 2, 2019, 5:29:02 AM7/2/19
to jenkinsc...@googlegroups.com
Kevin Williamson assigned an issue to Kevin Williamson
Change By: Kevin Williamson
Assignee: Karl Wirth Kevin Williamson

kwilliamson@perforce.com (JIRA)

unread,
Jul 2, 2019, 5:30:04 AM7/2/19
to jenkinsc...@googlegroups.com
Change By: Kevin Williamson
Status: In Review Fixed but Unreleased
Resolution: Fixed

kwilliamson@perforce.com (JIRA)

unread,
Jul 2, 2019, 5:30:05 AM7/2/19
to jenkinsc...@googlegroups.com
Change By: Kevin Williamson
Status: Fixed but Unreleased Closed
Reply all
Reply to author
Forward
0 new messages