[JIRA] (JENKINS-41089) Pipeline model round trip adds parenthesis where it need not add parenthesis

[jdumay@cloudbees.com (JIRA)]

James Dumay created an issue

Jenkins / JENKINS-41089 Pipeline model round trip adds parenthesis where it need not add parenthesis Issue Type: Story Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Jan/15 10:50 PM Priority: Minor Reporter: James Dumay A step in the original source looks like: sh 'mvn source:jar package -Dmaven.test.skip' When round tripped in the editor it will come out as sh('mvn source:jar package -Dmaven.test.skip') While the parentheses syntax is needed for multiple arguments it would be nice to prefer the shorthand for when multiple arguments are not used. Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-41089

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41089

Jenkins / JENKINS-41089 Pipeline model round trip adds parenthesis where it need not add parenthesis

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41089

Re: Pipeline model round trip adds parenthesis where it need not add parenthesis PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/95

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41089

Jenkins / JENKINS-41089

Pipeline model round trip adds parenthesis where it need not add parenthesis

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41089

Re: Pipeline model round trip adds parenthesis where it need not add parenthesis Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTAgent.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTPipelineDef.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTStages.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTStep.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/endpoints/ModelConverterActionStepsTest.java http://jenkins-ci.org/commit/pipeline-model-definition-plugin/b4d556f9075974bcb93c615cf7f59920e12915ef Log: Merge pull request #95 from abayer/jenkins-41090 [FIXED JENKINS-41090, JENKINS-41089] Groovy serialization cleanup Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/d17c0c7787f2...b4d556f90759

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41089

Re: Pipeline model round trip adds parenthesis where it need not add parenthesis

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTAgent.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTPipelineDef.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTStages.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTStep.java

http://jenkins-ci.org/commit/pipeline-model-definition-plugin/d255da0cd72c0e20e97a31d0072b3bf7bb35bd50 Log:

[FIXED JENKINS-41090, JENKINS-41089] Groovy serialization cleanup

Get rid of superfluous newlines, make sure we have a newline after 'label "foo"', don't serialize unneeded parentheses for single unnamed arguments for steps/functions.

Add Comment

[jdumay@cloudbees.com (JIRA)]

James Dumay commented on JENKINS-41089

Re: Pipeline model round trip adds parenthesis where it need not add parenthesis

Thanks Andrew Bayer

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-41089

Pipeline model round trip adds parenthesis where it need not add parenthesis

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)