[JIRA] (JENKINS-42551) Able to generate invalid declarative Jenkinsfiles

[kzantow@cloudbees.com (JIRA)]

Keith Zantow created an issue

Jenkins / JENKINS-42551 Able to generate invalid declarative Jenkinsfiles Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Mar/07 6:03 PM Priority: Critical Reporter: Keith Zantow In certain cases, it is possible to generate invalid Jenkinsfiles. I suggest during the JSON validation, we convert to declarative, and then also validate the declarative file, just to prevent invalid files from ever being created. An example JSON request that generates invalid declarative: {"pipeline":{"agent":{"type":"any"},"stages":[{"name":"Build","branches":[{"name":"default","steps":[{"name":"sh","arguments":[{"key":"script","value":{"isLiteral":true,"value":"echo 'hello\\'"}}]}]}]}]}}   Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

[kzantow@cloudbees.com (JIRA)]

Keith Zantow updated an issue

Jenkins / JENKINS-42551 Able to generate invalid declarative Jenkinsfiles

Change By: Keith Zantow

In certain cases, it is possible to generate invalid Jenkinsfiles.

For one thing, we need to escape backslashes. Additionally, I suggest during the JSON validation, we convert to declarative, and then also validate the declarative file, just to prevent invalid files from ever being created , since we can't actually load them into the editor again .

An example JSON request that generates invalid declarative:

{code:java} {"pipeline":{"agent":{"type":"any"},"stages":[{"name":"Build","branches":[{"name":"default","steps":[{"name":"sh","arguments":[{"key":"script","value":{"isLiteral":true,"value":"echo 'hello\\'"}}]}]}]}]}}{code}

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-42551

Re: Able to generate invalid declarative Jenkinsfiles Aaaaah - string hell. Good thought.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-42551

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-42551

Jenkins / JENKINS-42551

Able to generate invalid declarative Jenkinsfiles

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-42551

Re: Able to generate invalid declarative Jenkinsfiles PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/133

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-42551

Re: Able to generate invalid declarative Jenkinsfiles

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/endpoints/ModelConverterAction.java pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/Messages.properties pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/JSONValidationTest.java pipeline-model-definition/src/test/resources/json/errors/jsonMismatchedQuotes.json http://jenkins-ci.org/commit/pipeline-model-definition-plugin/c8d12fa9fd397d9443f4ea40e9d77035b2bd295f Log: [FIXED JENKINS-42551] Reject mismatched quotes and other invalid Groovy So now the JSON string "hello '" will cause a parse-time error. I also tweaked JSON validation endpoint to also convert to Jenkinsfile and validate that, so as to be sure we've actually got JSON that can be a valid Jenkinsfile, even if it has some kind of gotcha in it like the one fixed here.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-42551

Jenkins / JENKINS-42551

Able to generate invalid declarative Jenkinsfiles

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-42551 Able to generate invalid declarative Jenkinsfiles

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)