[JIRA] (JENKINS-5597) symlinks in archive trees lead to double archiving

4 views
Skip to first unread message

halvor.lund@gmail.com (JIRA)

unread,
Nov 21, 2016, 10:20:02 AM11/21/16
to jenkinsc...@googlegroups.com
Halvor Lund commented on Improvement JENKINS-5597
 
Re: symlinks in archive trees lead to double archiving

I can confirm that this still is an issue. It seems that symlinks to files are archived correctly, whereas symlinks to directories are not, and the whole directory is copied instead. Any plans for fixing this bug?

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

eric@blackbagtech.com (JIRA)

unread,
Jul 20, 2018, 7:41:02 PM7/20/18
to jenkinsc...@googlegroups.com
E H commented on Improvement JENKINS-5597

As well as being a a size issue, this breaks macOS Frameworks for code signing with a "bundle format is ambiguous (could be app or framework)" message.  I found this with stash/unstash, presumably the cause is the same.

This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

eric@blackbagtech.com (JIRA)

unread,
Jul 20, 2018, 8:03:03 PM7/20/18
to jenkinsc...@googlegroups.com
E H commented on Improvement JENKINS-5597

Drawing on https://github.com/jenkinsci/pipeline-examples/blob/master/pipeline-examples/unstash-different-dir/unstashDifferentDir.groovy, the attached "JENKINS-5597-example.groovy" pipeline script will demonstrate the problem of symlinks to directories becoming directories.

eric@blackbagtech.com (JIRA)

unread,
Jul 20, 2018, 8:03:07 PM7/20/18
to jenkinsc...@googlegroups.com
E H updated an issue
 
Jenkins / Improvement JENKINS-5597
Change By: E H
Attachment: JENKINS-5597-example.groovy

eric@blackbagtech.com (JIRA)

unread,
Jul 20, 2018, 8:05:02 PM7/20/18
to jenkinsc...@googlegroups.com
E H edited a comment on Improvement JENKINS-5597
Drawing on [https://github.com/jenkinsci/pipeline-examples/blob/master/pipeline-examples/unstash-different-dir/unstashDifferentDir.groovy,] the attached "JENKINS-5597-example.groovy" pipeline script will demonstrate the problem of symlinks to directories becoming directories.


If the stash-related issue should be a different Jira issue please let me know and I'll create one.

brian.murrell@intel.com (JIRA)

unread,
Jan 13, 2019, 11:27:03 PM1/13/19
to jenkinsc...@googlegroups.com

To be certain, this is a BUG not an Improvement.  Archiving means to store a copy as is, not to interpret and alter the archive such that it does not reflect what is being archived.

Why does this bug still exist 8.5 years later?

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

m_winter@gmx.de (JIRA)

unread,
Mar 20, 2019, 5:42:03 PM3/20/19
to jenkinsc...@googlegroups.com

Ran into an issue where a build made out of 1000 directory entries over 11 million for the ant DirectoryScanner because of symlinks to directories that again contains symlinks in a subfolder despite having an exclude pattern on the problematic folders.

archive pattern: gen/**/*log

exclude pattern: gen/out/modules/*/

The symlinks were all below gen/out/modules but DirectoryScanner still tried to read everything in before applying the exclude.

Agent process was started with -Xmx8g and ran oom.

 

m_winter@gmx.de (JIRA)

unread,
Mar 24, 2019, 4:34:03 AM3/24/19
to jenkinsc...@googlegroups.com

deshpande.aakash@gmail.com (JIRA)

unread,
Apr 11, 2019, 2:22:04 AM4/11/19
to jenkinsc...@googlegroups.com

Will this address a similar issue with stash/unstash as well ?

We are using git to checkout sources - which have symbolic links. Then when the sources are stashed and unstashed the symbolic links are lost. They appear as separate directories. This is leading up to a series of issues including bloating up of the sanbox size.

Abhishek.Sharma@amd.com (JIRA)

unread,
Oct 11, 2019, 1:52:03 PM10/11/19
to jenkinsc...@googlegroups.com

Hi,

Can someone please merge the changes to mains. We're very badly hurt by this issue, and currently building Jenkins manually for this change.

There is a pending merge request  https://github.com/jenkinsci/jenkins/pull/3947 that makes follow symlinks configurable.

 

Thanks,

Abhishek

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Apr 6, 2020, 5:42:05 AM4/6/20
to jenkinsc...@googlegroups.com
Oleg Nenashev resolved as Fixed
 

The change was released in Jenkins 2.230. Thanks to Daniel Beck Wadeck Follonier Jeff Thompson for reviews!

Change By: Oleg Nenashev
Status: Open Resolved
Assignee: Andrew Bayer
Resolution: Fixed
Released As: Jenkins 2.230
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages