[JIRA] (JENKINS-55349) Duplicate symbols in different plugins cause NPEs

1 view
Skip to first unread message

ullrich.hafner@gmail.com (JIRA)

unread,
Dec 27, 2018, 6:28:02 PM12/27/18
to jenkinsc...@googlegroups.com
Ulli Hafner created an issue
 
Jenkins / New Feature JENKINS-55349
Duplicate symbols in different plugins cause NPEs
Issue Type: New Feature New Feature
Assignee: Share Cheng
Components: code-coverage-api-plugin, warnings-ng-plugin, workflow-cps-plugin
Created: 2018-12-27 23:27
Priority: Minor Minor
Reporter: Ulli Hafner

If two different plugins define the same symbol name in steps or parameters then the workflow cps plugin can't instantiate the right element.

I.e., in JENKINS-55328 a user created a step

recordIssues tools: [checkStyle(), pmd(pattern: 'target/pmd.xml'), spotBugs(), cpd(pattern: 'target/cpd.xml')]

Since the user already installed the PMD plugin, the symbol pmd has been reserved for the step in the PMD plugin already. That means, rather then providing the pmd tool to my recordIssues step, it started the pmd step and set the corresponding array element to null.

The same happened in JENKINS-53181. In the comments Jesse Glick noted that this behavior could not be changed (or is hard to change). It would help other plugin developers, if in such cases at least the workflow-cps engine could provide a meaningful exception (with the conflicting Jenkinsfile line) rather then assigning null to a parameter.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,
Dec 27, 2018, 6:29:02 PM12/27/18
to jenkinsc...@googlegroups.com

ullrich.hafner@gmail.com (JIRA)

unread,
Dec 27, 2018, 6:29:02 PM12/27/18
to jenkinsc...@googlegroups.com
Ulli Hafner updated an issue
Change By: Ulli Hafner
Component/s: code-coverage-api-plugin
Component/s: warnings-ng-plugin

ullrich.hafner@gmail.com (JIRA)

unread,
Dec 27, 2018, 6:29:02 PM12/27/18
to jenkinsc...@googlegroups.com
Ulli Hafner assigned an issue to jesse rolph
Change By: Ulli Hafner
Assignee: Share Cheng jesse rolph

ullrich.hafner@gmail.com (JIRA)

unread,
Dec 27, 2018, 6:29:02 PM12/27/18
to jenkinsc...@googlegroups.com
Ulli Hafner assigned an issue to Unassigned
Change By: Ulli Hafner
Assignee: jesse rolph

ullrich.hafner@gmail.com (JIRA)

unread,
Dec 27, 2018, 6:29:03 PM12/27/18
to jenkinsc...@googlegroups.com
Ulli Hafner assigned an issue to Unassigned
Change By: Ulli Hafner
Assignee: Ulli Hafner

ullrich.hafner@gmail.com (JIRA)

unread,
Dec 27, 2018, 6:30:01 PM12/27/18
to jenkinsc...@googlegroups.com
Ulli Hafner updated an issue
Change By: Ulli Hafner
Issue Type: New Feature Bug

jglick@cloudbees.com (JIRA)

unread,
Jan 11, 2019, 5:06:01 PM1/11/19
to jenkinsc...@googlegroups.com

jglick@cloudbees.com (JIRA)

unread,
Jan 11, 2019, 5:06:02 PM1/11/19
to jenkinsc...@googlegroups.com
Jesse Glick updated an issue
Change By: Jesse Glick
Issue Type: Bug Improvement

jglick@cloudbees.com (JIRA)

unread,
Jan 11, 2019, 5:08:02 PM1/11/19
to jenkinsc...@googlegroups.com
Jesse Glick updated an issue
Change By: Jesse Glick
Labels: diagnostics robustness

ullrich.hafner@gmail.com (JIRA)

unread,
Jan 14, 2019, 4:41:03 PM1/14/19
to jenkinsc...@googlegroups.com
Ulli Hafner commented on Improvement JENKINS-55349
 
Re: Duplicate symbols in different plugins cause NPEs

It might make also sense that we have a tool that scans all plugin symbols for duplications, e.g. before these symbols are aggregated in our pipeline online help page. It is only a matter of time that someone else will create an object with a symbol that has been used already.

ullrich.hafner@gmail.com (JIRA)

unread,
Feb 13, 2019, 5:50:01 AM2/13/19
to jenkinsc...@googlegroups.com

jnord@cloudbees.com (JIRA)

unread,
Jul 24, 2019, 11:42:01 AM7/24/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages