[JIRA] (JENKINS-48475) Build step returns null if propagate set to true

[vsluzky23@gmail.com (JIRA)]

vadim sluzky commented on JENKINS-48475

Re: Build step returns null if propagate set to true I can not agree that this is a correct behavior. It's a blocker for the following use case I'm trying to implement: Run a set of tests represented by Jenkins Jobs For jobs that fail post name of the test and a link to a corresponding build For failing tests build step returns null and I can't get BUILD_URL May you suggest an alternative way to unblock me? Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-48475

Re: Build step returns null if propagate set to true

Set `propagate` to false.

Add Comment

[vsluzky23@gmail.com (JIRA)]

vadim sluzky commented on JENKINS-48475

Re: Build step returns null if propagate set to true

Got it. I set propagate to false and then analyzed result field. Thank you for quick help, Andrew!

Add Comment

[vsluzky23@gmail.com (JIRA)]

vadim sluzky commented on JENKINS-48475

Re: Build step returns null if propagate set to true

There is still a problem with that implementation. If propagate is set to false, all the corresponding tests are displayed in GREEN Is it possible to let the upstream  job know about failures?

Add Comment

[vsluzky23@gmail.com (JIRA)]

vadim sluzky edited a comment on JENKINS-48475

Re: Build step returns null if propagate set to true

There is still a problem with that implementation. If propagate is set to false, all the corresponding tests are displayed in GREEN Is it possible to let the upstream  job know about failures?

Are there any problems with returning real non-null result if wait is true?

Add Comment

[vsluzky23@gmail.com (JIRA)]

vadim sluzky edited a comment on JENKINS-48475

Re: Build step returns null if propagate set to true

There is still a problem with that implementation. If propagate is set to false, all the corresponding tests are displayed in GREEN Is it possible to let the upstream  job know about failures? Are there any problems with returning real non-null result if wait is true?

What is the logic behind using 'propagate' field to whether returning result? I strongly believe it should be returned or not based on 'wait' parameter and this is a valid non-minor defects that does not have a workaround

Add Comment

[vsluzky23@gmail.com (JIRA)]

vadim sluzky edited a comment on JENKINS-48475

Re: Build step returns null if propagate set to true

There is still a problem with that implementation. If propagate is set to false, all the corresponding tests are displayed in GREEN Is it possible to let the upstream  job know about failures? Are there any problems with returning real non-null result if wait is true?  What is the logic behind using 'propagate' field to whether returning result?

I strongly believe it should be returned or not based on 'wait' parameter and this is a valid non-minor defects defect that does not have a workaround and needs to be fixed

Add Comment

[vsluzky23@gmail.com (JIRA)]

vadim sluzky reopened an issue

I can not agree with resolution "Resolved" because it is "not a defect". If a build is not SUCCESSFUL, there is a need to have it results like a link to BUILD_URL. Consider the following use case:     Run Tests as Jenkins jobs called from pipeline     Provide links to jobs that failed The suggested solution is to set propagate to false that results in displaying all builds/tests as SUCCESSFUL - it's not acceptable. IMO, whether or not to return results of execution should depend on wait parameter. If wait is true, results should be available and should be returned. If wait is false - build is only launched without waiting to its completion - then result is not available. That should not be related to 'propagate'  Jenkins / JENKINS-48475

Build step returns null if propagate set to true

Change By: vadim sluzky Resolution: Not A Defect Status: Resolved Reopened

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-48475

Re: Build step returns null if propagate set to true So this is definitely a confusing setting, no question. The problem here is that propagate really just means "if the downstream build fails, this step fails too". That directly results in returning null - a failed Pipeline step can't return anything. I'll leave this open in case an alternative approach comes to mind, but I don't think there's a way to achieve what you want.

Add Comment

[vsluzky23@gmail.com (JIRA)]

vadim sluzky commented on JENKINS-48475

Re: Build step returns null if propagate set to true

An alternative might be parsing upstream's job output, but this looks like too weird workaround. I surmise that result's data is available if wait is true and can be returned - please correct me if I'm wrong

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-48475

Re: Build step returns null if propagate set to true

You can definitely act on the downstream run's result - def foo = build ...; if (foo.result != "SUCCESS") ..., e.g. But the build step itself will still be marked as successful.

Add Comment

[vsluzky23@gmail.com (JIRA)]

vadim sluzky commented on JENKINS-48475

Re: Build step returns null if propagate set to true

Yes, I tried that way and it's not acceptable in my case because build steps are marked as passed

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-48475

Re: Build step returns null if propagate set to true

Sorry to hear that - then you are stuck, since as I said, at least in current Pipeline design, a step can't both fail and return something.

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick updated an issue

Jenkins / JENKINS-48475

Build step returns null if propagate set to true

Change By: Jesse Glick Issue Type: Bug Improvement

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[wessely.werner@gmail.com (JIRA)]

Werner Wessely commented on JENKINS-48475

Re: Build step returns null if propagate set to true I am sure vadim figured it out already but heres what we do just for anybody else. We also need some info on failing downstreams, you can get it from the object thrown by the build step, for example the build number:   Its not the best thing ever but we just use it as a workaround for a different blue ocean problem that will hopefully be fixed soon: try { build(...) } catch (Exception e) { e.toString().split(" ").each { if(it.contains("#")) { def buildNumber = it.substring(1) ... } } }

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)