[JIRA] (JENKINS-58028) Move from gmaven-plugin to gmavenplus-plugin

[bitwiseman@gmail.com (JIRA)]

Liam Newman created an issue

Jenkins / JENKINS-58028 Move from gmaven-plugin to gmavenplus-plugin Issue Type: Task Assignee: Unassigned Components: plugin-pom Created: 2019-06-14 22:07 Priority: Minor Reporter: Liam Newman Jenkins plugins use a custom version of the gmaven-plugin that hasn't been updated in years. There is a gmavenplus-plugin that is maintained and is Java 11 compatible. The pipeline-model-definition plugin recently switched to using gmavenplus with only some additional spotbugs issues. Jenkins parent-pom should switch to gmavenplus and exclude gmaven. Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[bitwiseman@gmail.com (JIRA)]

Liam Newman updated an issue

Jenkins / JENKINS-58028 Move from gmaven-plugin to gmavenplus-plugin

Change By: Liam Newman

Jenkins plugins use a custom version of the gmaven-plugin that hasn't been updated in years. There is a gmavenplus-plugin that is maintained and is Java 11 compatible.

https://github.com/groovy/GMavenPlus

The pipeline-model-definition plugin recently switched to using gmavenplus with only some additional spotbugs issues.   Jenkins parent-pom should switch to gmavenplus and exclude gmaven.

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick commented on JENKINS-58028

Re: Move from gmaven-plugin to gmavenplus-plugin Ideally only in a profile activated by the presence of Groovy sources. Or just remove all support for Groovy from the parent POM, as it is a niche thing we do not really recommend. At least I would like to get rid of workflow-cps-plugin/src/test/groovy/ and its ilk. The main trouble with this option is that people do not read release notes when updating the parent POM (incl. most users of Dependabot), and in some cases a plugin using some Groovy would continue to compile yet be missing functionality—so we would either need to do a search for affected plugins, or introduce some kind of automated warning.

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman commented on JENKINS-58028

Re: Move from gmaven-plugin to gmavenplus-plugin

Jesse Glick It seems like something we could find a way to produce a warning/error for - https://maven.apache.org/enforcer/enforcer-rules/bannedPlugins.html . We could make both available to start and then ban gmaven in a later release. I understand you have a strong opinion about how groovy should and should not be used in the project, but that is a much larger change. This change, on the other hand, is almost a drop in replacement that unblocked one of our core plugins to build and run on Java 11.

Add Comment