[JIRA] (JENKINS-57847) NPE when using Vault Plugin with older version of vault

8 views
Skip to first unread message

anton@mostovoy.net (JIRA)

unread,
Jun 4, 2019, 1:13:02 PM6/4/19
to jenkinsc...@googlegroups.com
Anton Mostovoy created an issue
 
Jenkins / Bug JENKINS-57847
NPE when using Vault Plugin with older version of vault
Issue Type: Bug Bug
Assignee: Peter Tierno
Components: hashicorp-vault-plugin
Created: 2019-06-04 17:12
Priority: Major Major
Reporter: Anton Mostovoy

Using the latest version from master, and vault 0.9.0

 

ava.lang.NullPointerException
	at com.bettercloud.vault.api.Logical.read(Logical.java:73)
	at com.datapipe.jenkins.vault.VaultAccessor.read(VaultAccessor.java:52)
	at com.datapipe.jenkins.vault.VaultBuildWrapper.provideEnvironmentVariablesFromVault(VaultBuildWrapper.java:136)
	at com.datapipe.jenkins.vault.VaultBuildWrapper.setUp(VaultBuildWrapper.java:89)
	at org.jenkinsci.plugins.workflow.steps.CoreWrapperStep$Execution2.doStart(CoreWrapperStep.java:97)
	at org.jenkinsci.plugins.workflow.steps.GeneralNonBlockingStepExecution.lambda$run$0(GeneralNonBlockingStepExecution.java:77)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748) 

 

Looks like this was introduced in https://github.com/jenkinsci/hashicorp-vault-plugin/pull/23

also reported in a comment there https://github.com/jenkinsci/hashicorp-vault-plugin/pull/23#issuecomment-467215478

i can confirm that code in pr20 does work without this error

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

josh@hoblitt.com (JIRA)

unread,
Jun 5, 2019, 2:23:01 PM6/5/19
to jenkinsc...@googlegroups.com
Joshua Hoblitt commented on Bug JENKINS-57847
 
Re: NPE when using Vault Plugin with older version of vault

I have also observed this with current master (2.2.1-SNAPSHOT (private-54946854-jhoblitt)) and vault 1.0.0.

java.lang.NullPointerException
	at com.bettercloud.vault.api.Logical.read(Logical.java:73)
	at com.datapipe.jenkins.vault.VaultAccessor.read(VaultAccessor.java:52)
	at com.datapipe.jenkins.vault.VaultBuildWrapper.provideEnvironmentVariablesFromVault(VaultBuildWrapper.java:136)
	at com.datapipe.jenkins.vault.VaultBuildWrapper.setUp(VaultBuildWrapper.java:89)
	at org.jenkinsci.plugins.workflow.steps.CoreWrapperStep$Execution2.doStart(CoreWrapperStep.java:97)
	at org.jenkinsci.plugins.workflow.steps.GeneralNonBlockingStepExecution.lambda$run$0(GeneralNonBlockingStepExecution.java:77)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Finished: FAILURE

It also looks like there is something strange with the behavior of the "Vault Token Credential" Credentials type – when "updating it" the token field is always blank (no ***}}s) as are present with the {{2.2.0 release.

josephp90@gmail.com (JIRA)

unread,
Aug 19, 2019, 6:02:04 PM8/19/19
to jenkinsc...@googlegroups.com

Using v2.3.0 of hashicorp vault plugin you have specify engine version

josephp90@gmail.com (JIRA)

unread,
Aug 20, 2019, 1:46:02 AM8/20/19
to jenkinsc...@googlegroups.com
Joseph Petersen resolved as Fixed
 

With v2.3.1 you can also set the engine version on the vault configuration

Change By: Joseph Petersen
Status: Open Resolved
Assignee: Peter Tierno Joseph Petersen
Resolution: Fixed
Released As: https://github.com/jenkinsci/hashicorp-vault-plugin/releases/tag/hashicorp-vault-plugin-2.3.1

josephp90@gmail.com (JIRA)

unread,
Mar 7, 2020, 1:08:03 AM3/7/20
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Joseph Petersen
Change By: Joseph Petersen
Assignee: Joseph Petersen (old)
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages