[JIRA] (JENKINS-59605) Broken core.FormValidationTest#validate

[ogondza@gmail.com (JIRA)]

Oliver Gondža created an issue

Jenkins / JENKINS-59605 Broken core.FormValidationTest#validate Issue Type: Bug Assignee: Oliver Gondža Components: acceptance-test-harness Created: 2019-10-01 10:58 Priority: Major Reporter: Oliver Gondža As James has pointed out[1], the test was broken by a change I made. [1] https://github.com/jenkinsci/acceptance-test-harness/pull/515#discussion_r329985479 Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[ogondza@gmail.com (JIRA)]

Oliver Gondža started work on JENKINS-59605

Change By: Oliver Gondža Status: Open In Progress

Add Comment

[ogondza@gmail.com (JIRA)]

Oliver Gondža commented on JENKINS-59605

Re: Broken core.FormValidationTest#validate This problem here affects javascript based validation only. The problem is that AJAX based validation will add the <div/>[1] on success, but the javascript one does not[2]. Hence there is no easy way to tell, whether there is a validation that is pending or this is a successful result of JS validation (that keeps the DOM tree untouched). [1] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/core/src/main/java/hudson/util/FormValidation.java#L159 [2] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/war/src/main/webapp/scripts/hudson-behavior.js#L498

Add Comment