[JIRA] (JENKINS-61711) Git plugin global config incorrectly reports git not in PATH

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-61711 Git plugin global config incorrectly reports git not in PATH Change By: Mark Waite Summary: Git plugin global config incorrectly fails to find reports git not in PATH Add Comment

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya commented on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH Hi Mark Waite. I was trying to reproduce this bug and I can't figure out a way to do it. I'd like to know if this is a windows or a linux machine. As it can be seen, the environment variable `PATH` is being used to find the git executable and depending upon the OS, it will try to append PATH + "git" and try to check if that exists. Since you have mentioned that the git executable does exist on the path, it doesn't make sense to me how could the `FormValidation validateExecutable` can't find it.

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya edited a comment on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

Hi [~markewaite]. I was trying to reproduce this bug and I can't figure out a way to do it.

I'd like to know if this is a windows or a linux machine.

As it can be seen, the environment variable ` * PATH ` * is being used to find the git executable and depending upon the OS, it will try to append * PATH + "git" * and try to check if that exists. Since you have mentioned that the git executable _does_ exist on the path, it doesn't make sense to me how could the ` FormValidation validateExecutable` _validateExecutable_ can't find it.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

Rishabh Budhouliya thanks very much for investigating and for trying to duplicate the problem. I should have provided a precise set of steps that will duplicate the problem. The steps are: Install and enable the git LFS extension (if not already installed) Install Docker Clone my docker-lfs repository $ git clone https://github.com/MarkEWaite/docker-lfs.git Checkout the lts-with-plugins branch $ git checkout -b lts-with-plugins -t origin/lts-with-plugins Build the lts-with-plugins image $ ./docker_build.py Run the lts-with-plugins image $ ./docker_run.py --clean --quiet Open the newly started Jenkins in a web browser on port 8080 Open "Manage Jenkins" Open "Global Tool Configuration" Scroll down to show the git tool configuration Wait briefly while Jenkins checks for existence of the git tool, not that there is a red warning below that field which reports the tool is not available

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite edited a comment on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

[~rishabhbudhouliya] thanks very much for investigating and for trying to duplicate the problem.  I should have provided a precise set of steps that will duplicate the problem.  The steps are: # Install and enable the git LFS extension (if not already installed) # Install Docker # Clone my [docker-lfs repository|https://github.com/MarkEWaite/docker-lfs]   {{$ git clone https://github.com/MarkEWaite/docker-lfs.git}} # Checkout the lts branch   {{$ git checkout - b lts -t origin/lts}} # Remove the master branch   {{$ git branch -D --delete master}} # Checkout the lts- with-plugins branch

{{$ git checkout -b lts-with-plugins -t origin/lts-with-plugins}}

# Build the lts-with-plugins image   {{$ ./docker_build.py}} # Run the lts-with-plugins image   {{$ ./docker_run.py --clean --quiet}} # Open the newly started Jenkins in a web browser on port 8080 # Open "Manage Jenkins" # Open "Global Tool Configuration" # Scroll down to show the git tool configuration # Wait briefly while Jenkins checks for existence of the git tool, not that there is a red warning below that field which reports the tool is not available

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite edited a comment on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

[~rishabhbudhouliya] thanks very much for investigating and for trying to duplicate the problem.  I should have provided a precise set of steps that will duplicate the problem.  The steps are: # Install and enable the git LFS extension (if not already installed) # Install Docker # Clone my [docker-lfs repository|https://github.com/MarkEWaite/docker-lfs]   {{$ git clone https://github.com/MarkEWaite/docker-lfs.git}}

# Change to the cloned directory   {{$ cd docker-lfs}} # Checkout the lts branch   {{$ git checkout -b lts -t origin/lts}}

# Remove the master branch   {{$ git branch -D --delete master}}

# Checkout the lts-with-plugins branch

{{$ git checkout -b lts-with-plugins -t origin/lts-with-plugins}} # Build the lts-with-plugins image   {{$ ./docker_build.py}} # Run the lts-with-plugins image   {{$ ./docker_run.py --clean --quiet}} # Open the newly started Jenkins in a web browser on port 8080 # Open "Manage Jenkins" # Open "Global Tool Configuration" # Scroll down to show the git tool configuration # Wait briefly while Jenkins checks for existence of the git tool, not that there is a red warning below that field which reports the tool is not available

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite edited a comment on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

[~rishabhbudhouliya] thanks very much for investigating and for trying to duplicate the problem.  I should have provided a precise set of steps that will duplicate the problem.  The steps are: # Install and enable the git LFS extension (if not already installed) # Install Docker # Clone my [docker-lfs repository|https://github.com/MarkEWaite/docker-lfs]   {{$ git clone https://github.com/MarkEWaite/docker-lfs.git}} # Change to the cloned directory   {{$ cd docker-lfs}} # Checkout the lts branch   {{$ git checkout -b lts -t origin/lts}} # Remove the master branch   {{$ git branch -D --delete master}} # Checkout the lts-with-plugins branch   {{$ git checkout -b lts-with-plugins -t origin/lts-with-plugins}} # Build the lts-with-plugins image   {{$ ./docker_build.py}} # Run the lts-with-plugins image   {{$ ./docker_run.py --clean --quiet}} # Open the newly started Jenkins in a web browser on port 8080 # Open "Manage Jenkins" # Open "Global Tool Configuration" # Scroll down to show the git tool configuration

# Wait briefly while Jenkins checks for existence of the git tool, not note that there is a red warning below that field which reports the tool is not available

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

Rishabh Budhouliya I was concerned that the problem might be specific to my Docker image, so I tested a fresh download of Jenkins 2.222.1 run as a war file on my Ubuntu 18.04 computer. Steps in this test were: Download Jenkins 2.222.1 war file $ wget http://mirrors.jenkins.io/war-stable/2.222.1/jenkins.war Run war file $ java -jar jenkins.war Connect to the Jenkins instance on port 8080 with a web browser Enter the random admin password for Jenkins Create a user account in Jenkins Choose to install selected plugins from the install wizard, select "None", then select only the git plugin Complete the install wizard, watch the plugins as they install Open "Manage Jenkins" and the "Global Tool Configuration" page Review the "git" configured for the Default git tool, confirm that it reports that "git" cannot be found, even though there is a git installed in /usr/bin on my computer Thanks again for investigating!

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya updated an issue

Jenkins / JENKINS-61711

Git plugin global config incorrectly reports git not in PATH

Change By: Rishabh Budhouliya Attachment: Screenshot 2020-04-14 at 5.43.50 PM.png

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya commented on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH Many thanks for laying out the steps so clearly, I was able to reproduce the bug and I think I have found the problem. https://github.com/jenkinsci/jenkins/blob/d66bd8595e531749e842274a806eabab5cc16a32/core/src/main/java/hudson/util/DOSToUnixPathHelper.java#L68 Here, the executable file is built as "_dir + File.pathSeperator + exe" where File.pathSeperator should be used for multiple directories (: for unix, ; for windows).  I changed it to File.seperator (platform independent) and it is working correctly, here is a screenshot of my Jenkins UI:

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya edited a comment on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

Many thanks for laying out the steps so clearly, I was able to reproduce the bug and I think I have found the problem. [https://github.com/jenkinsci/jenkins/blob/d66bd8595e531749e842274a806eabab5cc16a32/core/src/main/java/hudson/util/DOSToUnixPathHelper.java#L68]

Here, the executable file is built as *"_dir + File.pathSeperator + exe"* where *File.pathSeperator* should be used for multiple directories (: for unix Unix , ; for windows).  For example, it was trying to find git executable in "/usr/local/bin:git" instead of "/usr/local/bin/git" I changed it to *File.seperator* (platform independent , "/" for Unix ) and it is working correctly, here is a screenshot of my Jenkins UI: !Screenshot 2020-04-14 at 5.43.50 PM.png!

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya edited a comment on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

Many thanks for laying out the steps so clearly, I was able to reproduce the bug and I think I have found the problem. [https://github.com/jenkinsci/jenkins/blob/d66bd8595e531749e842274a806eabab5cc16a32/core/src/main/java/hudson/util/DOSToUnixPathHelper.java#L68]

Here, the executable file is built as *"_dir + File.pathSeperator + exe"* where *File.pathSeperator* should be used for multiple directories (: for Unix, ; for windows).

For example, it was trying to find git executable in "/usr/local/bin:git" instead of "/usr/local/bin/git"

I changed it to *File.seperator* (platform independent, "/" for Unix) and it is working correctly, here is a screenshot of my Jenkins UI: !Screenshot 2020-04-14 at 5.43.50 PM.png |width=417,height=260 !

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

Thanks for that research and for finding the root of the problem. Will you submit a pull request with a fix and with tests to confirm that the fix is working as expected? Since the issue seems to be in Jenkins core, I've reassigned the component as core.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-61711

Git plugin global config incorrectly reports git not in PATH

Change By: Mark Waite Component/s: core Component/s: git-plugin

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya commented on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH Sure, I'll raise a pull request with the fix and tests.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite edited a comment on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

Thanks for that research and for finding the root of the problem.  Will you submit a pull request with a fix and with tests to confirm that the fix is working as expected?

Since the issue seems to be in Jenkins core, I've reassigned the component as {{core}}.

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya commented on JENKINS-61711

Re: Git plugin global config incorrectly reports git not in PATH

I have raised a pull request: https://github.com/jenkinsci/jenkins/pull/4653  Thanks.

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya started work on JENKINS-61711

Change By: Rishabh Budhouliya Status: Open In Progress

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya assigned an issue to Rishabh Budhouliya

Jenkins / JENKINS-61711

Git plugin global config incorrectly reports git not in PATH

Change By: Rishabh Budhouliya Assignee: Rishabh Budhouliya

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya updated JENKINS-61711

Jenkins / JENKINS-61711 Git plugin global config incorrectly reports git not in PATH

Change By: Rishabh Budhouliya Status: In Progress Review

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated JENKINS-61711

Jenkins / JENKINS-61711 Git plugin global config incorrectly reports git not in PATH

Change By: Oleg Nenashev Status: In Review Resolved Resolution: Fixed Released As: Jenkins 2.232

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-61711 Git plugin global config incorrectly reports git not in PATH

Change By: Oleg Nenashev Environment: Jenkins 2. 22 222 .1 Git plugin 4.2.2 Git client plugin 3.2.1

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-61711 Git plugin global config incorrectly reports git not in PATH

Change By: Oleg Nenashev Labels: configuration lts-candidate newbie-friendly

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite closed an issue as Fixed

Jenkins / JENKINS-61711 Git plugin global config incorrectly reports git not in PATH

Change By: Mark Waite Status: Resolved Closed

Add Comment

[ogondza@gmail.com (JIRA)]

Oliver Gondža updated an issue

Jenkins / JENKINS-61711 Git plugin global config incorrectly reports git not in PATH

Change By: Oliver Gondža Labels: configuration lts 2.222.4 - candidate fixed configuration newbie-friendly

Add Comment