[JIRA] (JENKINS-60354) Updated pipeline build step does not work with retry, catchError, or warnError

12 views
Skip to first unread message

dnusbaum@cloudbees.com (JIRA)

unread,
Dec 4, 2019, 5:23:03 PM12/4/19
to jenkinsc...@googlegroups.com
Devin Nusbaum updated an issue
 
Jenkins / Bug JENKINS-60354
Updated pipeline build step does not work with retry, catchError, or warnError
Change By: Devin Nusbaum
Summary: Updated pipeline build step does not work with retry , catchError, or warnError
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

me@basilcrow.com (JIRA)

unread,
Dec 9, 2019, 2:19:02 PM12/9/19
to jenkinsc...@googlegroups.com
Basil Crow commented on Bug JENKINS-60354
 
Re: Updated pipeline build step does not work with retry, catchError, or warnError

It might be worth considering the use case in JENKINS-51454 as part of the design of this solution.

dnusbaum@cloudbees.com (JIRA)

unread,
Dec 9, 2019, 2:43:02 PM12/9/19
to jenkinsc...@googlegroups.com

Basil Crow Good point, I commented on that ticket. I think that the approach from this PR could be tweaked a bit to use https://github.com/jenkinsci/workflow-step-api-plugin/pull/51 (if a setter was added) to change the value of FlowInterruptedException.actualInterruption from true to false when the exception propagates past the timeout step that threw the exception, in which case the fix for this issue would fix that issue as well.

dnusbaum@cloudbees.com (JIRA)

unread,
Dec 11, 2019, 1:54:03 PM12/11/19
to jenkinsc...@googlegroups.com
Change By: Devin Nusbaum
Status: In Progress Review

dnusbaum@cloudbees.com (JIRA)

unread,
Dec 11, 2019, 1:54:03 PM12/11/19
to jenkinsc...@googlegroups.com
 
Re: Updated pipeline build step does not work with retry, catchError, or warnError

Ok, PRs are up for review:

catchError and warnError are not as affected as retry as I first thought, because they catch all interruptions by default, and only rethrow them if the user passes catchInterruptions: false (I thought the default was true).

dnusbaum@cloudbees.com (JIRA)

unread,
Dec 11, 2019, 1:54:03 PM12/11/19
to jenkinsc...@googlegroups.com
Devin Nusbaum started work on Bug JENKINS-60354
 
Change By: Devin Nusbaum
Status: Open In Progress

dnusbaum@cloudbees.com (JIRA)

unread,
Dec 11, 2019, 1:55:04 PM12/11/19
to jenkinsc...@googlegroups.com
Devin Nusbaum assigned an issue to Devin Nusbaum
 
Change By: Devin Nusbaum
Assignee: Devin Nusbaum

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 3, 2020, 5:13:02 PM1/3/20
to jenkinsc...@googlegroups.com
 

A fix for this issue has been released in Pipeline: Basic Steps Plugin 2.19 and Pipeline: Build Step Plugin 2.11. Both plugins must be updated for the fix to take effect. Thanks Jonathan B for reporting the issue!
Change By: Devin Nusbaum
Status: In Review Resolved
Resolution: Fixed
Released As: workflow-basic-steps 2.19, pipeline-build-step 2.11, workflow-step-api 2.22
Reply all
Reply to author
Forward
0 new messages