[JIRA] (JENKINS-60972) Rename the root breadcrumb

16 views
Skip to first unread message

fqueiruga@cloudbees.com (JIRA)

unread,
Feb 5, 2020, 4:29:03 AM2/5/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado created an issue
 
Jenkins / Story JENKINS-60972
Rename the root breadcrumb
Issue Type: Story Story
Assignee: Unassigned
Attachments: rootbreadcrumb.png
Components: core
Created: 2020-02-05 09:28
Priority: Minor Minor
Reporter: Félix Queiruga Balado

One of the items discussed on the UX SIG meetings (https://jenkins.io/sigs/ux/) was renaming the root breadcrumb to "Home". The reason for this is that it can be confusing having Jenkins in 2 consecutive lines.

 

An example of how it could look:

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 5, 2020, 5:29:04 AM3/5/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado updated an issue
Change By: Félix Queiruga Balado
Labels: newbie-friendly
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 5, 2020, 5:33:02 AM3/5/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado updated an issue
One of the items discussed on the UX SIG meetings ([https://jenkins.io/sigs/ux/]) was renaming the root breadcrumb to _"Home"_. The reason for this is that it can be confusing having Jenkins in 2 consecutive lines.


 

An example of how it could look:
!rootbreadcrumb.png!

The solution probably should take into account i18n capabilities.

sladynnunes98@gmail.com (JIRA)

unread,
Mar 15, 2020, 2:44:03 AM3/15/20
to jenkinsc...@googlegroups.com
Sladyn Nunes commented on Story JENKINS-60972
 
Re: Rename the root breadcrumb

I could get started with this issue. Could you point me to the code ? Félix Queiruga Balado

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 5:50:03 AM3/16/20
to jenkinsc...@googlegroups.com

It would be great if you can work on this one!

TBH there's no good support for breadcrumbs atm in Jenkins. They are just generated iterating through request ancestors, something that I guess is provided by Stapler (https://github.com/jenkinsci/jenkins/blob/07c48b03fb4c651e7314e7adbe3a0ef0fe249586/core/src/main/resources/lib/layout/breadcrumbBar.jelly#L44).

A hacky way to do it that comes to mind could be to check if the ancestor points to the rootURL, then it could be replaced.

That said, I'd favour using some Java code to do this. If we get a Breadcrumbs module going on, then we can expand it in the future with some utilities like:

  • Get the last breadcrumb item.
  • Check if a breadcrumb item is the current one (good for styling purposes).
  • Prepend/append items to the breadcrumbs.

 

sladynnunes98@gmail.com (JIRA)

unread,
Mar 17, 2020, 2:05:02 AM3/17/20
to jenkinsc...@googlegroups.com

Sounds like a really good plan, so basically we would like the jelly functionality to happen via java code, also where would such a module go in the file hierarchy jenkins/core/src/main/resources/breadcrumb ?

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 17, 2020, 12:48:02 PM3/17/20
to jenkinsc...@googlegroups.com

Something like that indeed. My OG idea was to to have on the Java side 2 models:

  • Breadcrumbs: has the logic to build the whole breadcrumb trail (maybe a getBreadcrumbItems method) and hooked into the jelly view. It would also allow prepending and appending breadcrumbs, and renaming the first one (??)
  • BreadcrumbItem: has logic to determine if it's the last one, get the parent, check if it has a contextual menu, etc.

Then on the jelly side you would get the breadcrumb model and iterate on the breadcrumb items

levimwill@gmail.com (JIRA)

unread,
Apr 8, 2020, 1:03:04 AM4/8/20
to jenkinsc...@googlegroups.com
Levi Williamson assigned an issue to Levi Williamson
Change By: Levi Williamson
Assignee: Levi Williamson

sladynnunes98@gmail.com (JIRA)

unread,
Apr 8, 2020, 1:07:07 AM4/8/20
to jenkinsc...@googlegroups.com
Sladyn Nunes assigned an issue to Sladyn Nunes
Change By: Sladyn Nunes
Assignee: Levi Williamson Sladyn Nunes

fqueiruga@cloudbees.com (JIRA)

unread,
Apr 8, 2020, 5:24:02 AM4/8/20
to jenkinsc...@googlegroups.com

Levi Williamson Sladyn has already started work on this one, the PR can be found here: https://github.com/jenkinsci/jenkins/pull/4634

Reply all
Reply to author
Forward
0 new messages