[JIRA] (JENKINS-60141) Excessive number of "login -s" requests

[jbateman@qti.qualcomm.com (JIRA)]

James Bateman created an issue

Jenkins / JENKINS-60141 Excessive number of "login -s" requests Issue Type: Bug Assignee: Rob Petti Components: perforce-plugin Created: 2019-11-12 11:25 Labels: jenkins plugin Priority: Minor Reporter: James Bateman Change JENKINS-44166 of the Jenkins P4 plugin modified the plugin to work in cases when a pre-login perforce triggers was being used. The 'fix' for the above issue: https://github.com/jenkinsci/p4-plugin/commit/ecbf8628e4f7104f73ab329b9b81065bc19fc44d now means that a 'p4 login -s' call is made to the Perforce server during each and every call to the isLogin() method. This can literally result in 10,000's of 'p4 login -s' requests an hour and cause the server to lock up (by using up all the available TCP sockets). The consequence being very similar to a DoS attach on the Perforce server. Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[rob.petti@gmail.com (JIRA)]

Rob Petti assigned an issue to Paul Allen

Jenkins / JENKINS-60141 Excessive number of "login -s" requests

Change By: Rob Petti Assignee: Rob Petti Paul Allen

Add Comment

[rob.petti@gmail.com (JIRA)]

Rob Petti updated an issue

Jenkins / JENKINS-60141 Excessive number of "login -s" requests

Change By: Rob Petti Component/s: p4-plugin Component/s: perforce-plugin

Add Comment

[rob.petti@gmail.com (JIRA)]

Rob Petti commented on JENKINS-60141

Re: Excessive number of "login -s" requests Wrong plugin. Perforce-plugin is deprecated and no longer supported. Please make sure you are filing tickets under the correct plugin (p4-plugin).

Add Comment

[jbateman@qti.qualcomm.com (JIRA)]

James Bateman updated an issue

Jenkins / JENKINS-60141

Excessive number of "login -s" requests

Change By: James Bateman Priority: Minor Major

Add Comment

[kwirth@perforce.com (JIRA)]

Karl Wirth assigned an issue to Karl Wirth

Jenkins / JENKINS-60141 Excessive number of "login -s" requests

Change By: Karl Wirth Assignee: Paul Allen Karl Wirth

Add Comment

[kwirth@perforce.com (JIRA)]

Karl Wirth updated an issue

Jenkins / JENKINS-60141 Excessive number of "login -s" requests

Change By: Karl Wirth Labels: P4_SUPPORT jenkins plugin

Add Comment

[kwirth@perforce.com (JIRA)]

Karl Wirth commented on JENKINS-60141

Re: Excessive number of "login -s" requests James Bateman - Again sorry for missing this one. It bypassed our monitoring scripts.   We have the problem that we provide the endpoints and Jenkins calls us as needed and there is no continuity or object sharing between calls. This means that we can never be sure if we are logged in or not. As part of the work to reduce 'p4 client -i' we did try and cut down on some of the 'p4 login' commands already.   I will produce some example here on number of 'login -s' for a simple script then will pass to the developers.

Add Comment

[kwirth@perforce.com (JIRA)]

Karl Wirth updated an issue

Jenkins / JENKINS-60141

Excessive number of "login -s" requests

Change By: Karl Wirth Attachment: log.case Attachment: log.poll

Add Comment

[kwirth@perforce.com (JIRA)]

Karl Wirth commented on JENKINS-60141

Re: Excessive number of "login -s" requests Sample of a basic freestyle job with a manual workspace executed on a slave. Polling enabled but polling did not trigger the job. Poll Now was clicked to collect the polling P4 commands.   Single Freestyle job run through the GUI: # P4 commands $ grep user- log.case | grep jenkins | wc -l 58 # P4 info or login commands $ grep user- log.case | grep jenkins | grep "login\|info" | wc -l 37 Polling for the freestyle job: # P4 Commands $ grep user log.poll | grep jenkins | wc -l 9 # P4 info or login commands $ grep user log.poll | grep jenkins | grep "login\|info" | wc -l 5 Have attached the logs for the above output.

Add Comment

[kwirth@perforce.com (JIRA)]

Karl Wirth assigned an issue to Unassigned

Jenkins / JENKINS-60141

Excessive number of "login -s" requests

Change By: Karl Wirth Assignee: Karl Wirth

Add Comment

[kwirth@perforce.com (JIRA)]

Karl Wirth updated an issue

Jenkins / JENKINS-60141 Excessive number of "login -s" requests

Change By: Karl Wirth Labels: P4_SUPPORT P4_A P4_VERIFY jenkins plugin

Add Comment

[cbopardikar@perforce.com (JIRA)]

Charusheela Bopardikar started work on JENKINS-60141

Change By: Charusheela Bopardikar Status: Open In Progress

Add Comment

[cbopardikar@perforce.com (JIRA)]

Charusheela Bopardikar commented on JENKINS-60141

Re: Excessive number of "login -s" requests Refactored the code to reduce number of times login -s is called.

Add Comment

[cbopardikar@perforce.com (JIRA)]

Charusheela Bopardikar assigned an issue to Charusheela Bopardikar

Jenkins / JENKINS-60141

Excessive number of "login -s" requests

Change By: Charusheela Bopardikar Assignee: Charusheela Bopardikar

Add Comment

[cbopardikar@perforce.com (JIRA)]

Charusheela Bopardikar edited a comment on JENKINS-60141

Re: Excessive number of "login -s" requests

Refactored the code to reduce number of times login -s is called.

[https://github.com/jenkinsci/p4-plugin/pull/112]

Add Comment

[cbopardikar@perforce.com (JIRA)]

Charusheela Bopardikar updated JENKINS-60141

Jenkins / JENKINS-60141

Excessive number of "login -s" requests

Change By: Charusheela Bopardikar Status: In Progress Fixed but Unreleased Resolution: Fixed

Add Comment

[cbopardikar@perforce.com (JIRA)]

Charusheela Bopardikar updated JENKINS-60141

Released in 1.10.9

Jenkins / JENKINS-60141 Excessive number of "login -s" requests

Change By: Charusheela Bopardikar Status: Fixed but Unreleased Closed

Add Comment