[JIRA] (JENKINS-58126) Make Parsing for Plugin Manager CLI More Robust

7 views
Skip to first unread message

natasha.stopa@gmail.com (JIRA)

unread,
Jun 20, 2019, 3:04:02 PM6/20/19
to jenkinsc...@googlegroups.com
Natasha Stopa created an issue
 
Jenkins / Task JENKINS-58126
Make Parsing for Plugin Manager CLI More Robust
Issue Type: Task Task
Assignee: Natasha Stopa
Components: plugin-installation-manager-tool
Created: 2019-06-20 19:03
Labels: gsoc-2019 plugin-manager
Priority: Minor Minor
Reporter: Natasha Stopa

The parsing for the plugin manager needs to be more robust. It needs to take into account unwanted characters, a better way to split on ":", and recognize requested plugin parameters.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

natasha.stopa@gmail.com (JIRA)

unread,
Jul 10, 2019, 5:55:02 PM7/10/19
to jenkinsc...@googlegroups.com
Natasha Stopa started work on Task JENKINS-58126
 
Change By: Natasha Stopa
Status: Open In Progress

natasha.stopa@gmail.com (JIRA)

unread,
Jul 10, 2019, 5:57:03 PM7/10/19
to jenkinsc...@googlegroups.com
Natasha Stopa commented on Task JENKINS-58126
 
Re: Make Parsing for Plugin Manager CLI More Robust

Kept parsing to be on ":", but added checks for blank lines and comments.  

Partially fixed in https://github.com/jenkinsci/plugin-installation-manager-tool/pull/27, but url input still broken.

Fixed again in: https://github.com/jenkinsci/plugin-installation-manager-tool/pull/28

 

 

natasha.stopa@gmail.com (JIRA)

unread,
Jul 12, 2019, 1:17:02 PM7/12/19
to jenkinsc...@googlegroups.com
Change By: Natasha Stopa
Status: In Progress Review

natasha.stopa@gmail.com (JIRA)

unread,
Jul 12, 2019, 1:19:02 PM7/12/19
to jenkinsc...@googlegroups.com
Natasha Stopa edited a comment on Task JENKINS-58126
Kept parsing to be on ":", but added checks for blank lines and comments.    Pinged the platform sig Gitter channel and in the install-plugins.sh if a url was entered, a placeholder was still kept for version, so I kept it this way. Also asked them about changing delimiters and they wanted to keep the ":" delimiter.

Partially fixed in [https://github.com/jenkinsci/plugin-installation-manager-tool/pull/27], but url input still broken.

Fixed again in: [https://github.com/jenkinsci/plugin-installation-manager-tool/pull/28]

 

 

natasha.stopa@gmail.com (JIRA)

unread,
Jul 25, 2019, 2:24:02 PM7/25/19
to jenkinsc...@googlegroups.com
Change By: Natasha Stopa
Status: In Review Resolved
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages