[JIRA] (JENKINS-41495) Jenkins Update for plugins URL not working in 2.32.1 version

[sharathinfy@gmail.com (JIRA)]

sharat sathyanarayan updated an issue

Jenkins / JENKINS-41495 Jenkins Update for plugins URL not working in 2.32.1 version Change By: sharat sathyanarayan Summary: Kenkins Jenkins Update for plugins URL not working in 2.32.1 version Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[cristian@uroz.cat (JIRA)]

Cristian Uroz commented on JENKINS-41495

Re: Jenkins Update for plugins URL not working in 2.32.1 version Same here with version 2.32.1 In manage jenkins, when "check now" is pushed this exception is returned java.net.MalformedURLException: no protocol: ?id=default&version=2.32.1 at java.net.URL.<init>(Unknown Source) at java.net.URL.<init>(Unknown Source) at java.net.URL.<init>(Unknown Source) at hudson.model.UpdateSite.updateDirectlyNow(UpdateSite.java:180) at hudson.PluginManager.doCheckUpdatesServer(PluginManager.java:1619) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:335) at org.kohsuke.stapler.interceptor.RequirePOST$Processor.invoke(RequirePOST.java:52) at org.kohsuke.stapler.PreInvokeInterceptedFunction.invoke(PreInvokeInterceptedFunction.java:26) at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:175) at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:108) at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:124) at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.MetaClass$2.doDispatch(MetaClass.java:174) at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649) at org.kohsuke.stapler.Stapler.service(Stapler.java:238) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:135) at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:126) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84) at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249) at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76) at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:553) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) at org.eclipse.jetty.server.Server.handle(Server.java:499) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257) at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544) at winstone.BoundedExecutorService$1.run(BoundedExecutorService.java:77) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source)

Add Comment

[cristian@uroz.cat (JIRA)]

Cristian Uroz edited a comment on JENKINS-41495

Re: Jenkins Update for plugins URL not working in 2.32.1 version

Same here with version 2.32.1

In manage jenkins plugins , when "check now" is pushed this exception is returned {code}

{code}

Add Comment

[cristian@uroz.cat (JIRA)]

Cristian Uroz commented on JENKINS-41495

Re: Jenkins Update for plugins URL not working in 2.32.1 version

After checking https://github.com/jenkinsci/jenkins/blob/jenkins-2.32.2/core/src/main/java/hudson/model/UpdateCenter.java#L846 I discovered the problem is in JENKINS_HOME/hudson.model.UpdateCenter.xml. For some reason, default site url is blank and "Load" function will not check correctly as it is only checking for default ID existance and no checking further if URL is default one or at least not blank or well-formed. Workaround/Solution: Add default update site http://updates.jenkins-ci.org/update-center.json in JENKINS_HOME/hudson.model.UpdateCenter.xml

Add Comment

[devld@ikedam.jp (JIRA)]

ikedam updated an issue

Jenkins / JENKINS-41495

Jenkins Update for plugins URL not working in 2.32.1 version

sharat sathyanarayan "id=simpleupdatesite" means this is an issue of SimpleUpdateSite plugin. I could reproduce the issue. Uninstalling SimpleUpdateSite plugin and restarting Jenkins resolved the issue. I changed the component/s to simpleupdatesite-plugin. Change By: ikedam Component/s: simpleupdatesite-plugin Component/s: update-sites-manager-plugin

Add Comment

[devld@ikedam.jp (JIRA)]

ikedam commented on JENKINS-41495

Re: Jenkins Update for plugins URL not working in 2.32.1 version Cristian Uroz Broken hudson.model.UpdateCenter.xml can cause any issue. I couldn't reproduce the issue with Jenkins 2.32.2 with updatesites-manager plugin, and I'm not sure it's actually related to updatesites-manager plugin. Please create a new ticket when you find the cause.

Add Comment

[cristian@uroz.cat (JIRA)]

Cristian Uroz commented on JENKINS-41495

Re: Jenkins Update for plugins URL not working in 2.32.1 version

ikedam The error is not related with this plugin. It is having hudson.model.UpdateCenter.xml url for default site blank (or with a malformed url). If you want to reproduce this error just keep deafult site in that file but with an empty url. As I pointed before here: https://github.com/jenkinsci/jenkins/blob/jenkins-2.32.2/core/src/main/java/hudson/model/UpdateCenter.java#L846 Load function will scan for default site inside hudson.model.UpdateCenter.xml and if it cannot find it, will create one. If default site already exist, load function will not check further if url is valid or at least not empty.

Add Comment

[devld@ikedam.jp (JIRA)]

ikedam commented on JENKINS-41495

Re: Jenkins Update for plugins URL not working in 2.32.1 version

Cristian Uroz The problem is what made the url empty. If it occurs with some specific opearations on Jenkins GUI, it should be fixed as a bug. Let me know if you secceeded to find the steps to reproduce it.

Add Comment