Request for commit privs for github plugin

[Daniel Barker]

I am wanting commit privs for the github plugin at https://github.com/jenkinsci/github-plugin. I am looking to pull in PR #37. I'll also review the rest of the pending PR's and close them or pull them in as necessary. Thank you.

[Oleg Nenashev]

Hi Daniel,

The PR waits for 4 days only.
Have you explicitly asked somebody to review the PR? Probably, Kohsuke or Stephen (they have released previous versions of the plugin) will be able to review changes. GitHub plugin is very popular, so you will definitely get the response after "making some noise".

Useful guidelines: https://wiki.jenkins-ci.org/display/JENKINS/contributing

Best regards,
Oleg Nenashev

четверг, 9 января 2014 г., 18:51:10 UTC+4 пользователь Daniel Barker написал:

[Daniel Barker]

Hi Oleg,

This was a second PR. Another colleague of mine was monitoring the previous PR. I have emailed Kohsuke, but it didn't look like Stephen has been around for awhile. If I get commit privs, then I will review this PR and the others related to it to determine which one if any are good to be pulled in. At the moment, it doesn't seem that this repo is being actively maintained, and Kohsuke has more than enough to do elsewhere.

Regards,

Daniel Barker

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/xuouo1N4158/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Oleg Nenashev]

Daniel,

You can find my comments in the PR

Best regards,
Oleg Nenashev

суббота, 11 января 2014 г., 0:25:48 UTC+4 пользователь Oleg Nenashev написал:

[Daniel Barker]

I saw them, and I agree. I was thinking a more robust system would be advisable, but I haven't developed one yet, because the repo doesn't seem to be monitored well. I'd prefer a selection within the manager. Thanks for the feedback.

--