Requesting commit access to powershell-plugin

17 views
Skip to first unread message

Chris Albrecht

unread,
Jun 25, 2015, 10:13:33 AM6/25/15
to jenkin...@googlegroups.com
I've sent a pull request to the powershell-plugin to launch powershell in non-interactive mode so that scripts that prompt for user input will no longer cause jobs to hang.

No one has responded to my pull request, so can I be given commit access to the repo so that I can merge and then publish an updated release?

My GitHub account is chrisalbrecht.

Thanks,
Chris

Christopher Orr

unread,
Jun 26, 2015, 8:29:48 AM6/26/15
to jenkin...@googlegroups.com
On 25/06/15 16:13, Chris Albrecht wrote:
> I've sent a pull request
> <https://github.com/jenkinsci/powershell-plugin/pull/3> to the
> powershell-plugin <https://github.com/jenkinsci/powershell-plugin> to
> launch powershell in non-interactive mode so that scripts that prompt
> for user input will no longer cause jobs to hang.
>
> No one has responded to my pull request, so can I be given commit access
> to the repo so that I can merge and then publish an updated release?

There doesn't seem to be a maintainer, and the last person who asked for
push commits didn't do a release and hasn't done anything since, so this
seems fine.

There don't seem to be any backwards-compatibility breaking changes in
those unreleased commits, though this change is a tiny bit questionable:
https://github.com/jenkinsci/powershell-plugin/commit/232a1ba#diff-7ff1de586b2ff01ad815df2206ddc9b1

So if you can test that jobs configured with v1.2 of the plugin still
work with those changes and your changes, I say feel free to release :)


> My GitHub account is chrisalbrecht.

You should get an invite email from GitHub.

Regards,
Chris
Reply all
Reply to author
Forward
0 new messages