URLTrigger plugin maintainer

[Tony Noble]

Hi,

I was looking to suggest some changes / fixes to this plugin as it's one I use on a daily basis.  However, I note the plugin is looking for a maintainer, so I guess it's not actively being developed?

I'm happy to take on maintenance of this plugin, if this is the case - my github id is TonyNoble and Jenkins infrastructure id is StealthDJ

Cheers,

Tony

[Oleg Nenashev]

Hi Tony,

Yes, the plugin is not being actively developed. There are some discussions about reworking the underlying EnvInject and XTrigger libraries, but we are not there yet. Any contributions will br more than welcome.

I have granted you permissions, you should receive an invitation to the jenkinsci GitHub organization soon.
Please update the Wiki and release permissions before doing the release.

Welcome aboard!

BR, Oleg

понедельник, 29 января 2018 г., 18:47:32 UTC+1 пользователь Tony Noble написал:

[Tony Noble]

Hi Oleg,

Thanks.  The change I have in mind would be cleaner if at least some of the work was done in EnvInject plugin - do I need to be added as a maintainer for this as well?

Tony

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/58786d4b-d8a5-43d1-896a-c0e769b8162d%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Oleg Nenashev]

No need if you do not want to take full ownership of EnvInject.
It's up for adoption, but I still kinda maintain it. So I am happy to review/integrate your PRs.

Generally, I would recommend the following upgrade path:

• Convert XTrigger lib to a plugin (may require some compatibility evaluation)
• Update URL Trigger to use recent Plugin POMs and cleanup issues reported by analysis tools we integrated into the default flow
  
• Make XTrigger lib to depend on EnvInject API plugin
• Contribute changes to EnvInject API if possible. EnvInject plugin itself would be rather a fallback
  

Hopefully it helps. Do not hesitate to request my reviews if needed. There are also some pending pull requests for the plan proposed above (e.g. from Alex Johnson).

BR, Oleg

пятница, 2 февраля 2018 г., 17:11:54 UTC+1 пользователь Tony Noble написал:

Hi Oleg,

Thanks.  The change I have in mind would be cleaner if at least some of the work was done in EnvInject plugin - do I need to be added as a maintainer for this as well?

Tony

On Wed, Jan 31, 2018 at 7:44 AM, Oleg Nenashev <o.v.ne...@gmail.com> wrote:

Hi Tony,

Yes, the plugin is not being actively developed. There are some discussions about reworking the underlying EnvInject and XTrigger libraries, but we are not there yet. Any contributions will br more than welcome.

I have granted you permissions, you should receive an invitation to the jenkinsci GitHub organization soon.
Please update the Wiki and release permissions before doing the release.

Welcome aboard!

BR, Oleg

понедельник, 29 января 2018 г., 18:47:32 UTC+1 пользователь Tony Noble написал:

Hi,

I was looking to suggest some changes / fixes to this plugin as it's one I use on a daily basis.  However, I note the plugin is looking for a maintainer, so I guess it's not actively being developed?

I'm happy to take on maintenance of this plugin, if this is the case - my github id is TonyNoble and Jenkins infrastructure id is StealthDJ

Cheers,

Tony

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.