Requesting commit rights to Jenkins Maven Project Plug-in re. PR#56

[apr...@tibco.com]

Good day jenkinsci-dev,

I submitted GitHub Pull Request #56 over two months ago, and requested a code review one month ago, all to no avail.

Accordingly, please grant me committer rights so that I can integrate this PR myself.

Thanks,

aprice at tibco.com aka GitHub demonfiddler

[Oleg Nenashev]

Hi,

From what I see...

• the PR has been created on Dec 10th (34 days ago)
  
• the review has been requested on January 4th (10 days ago)

Due to the Christmas shutdowns the community capacity was lower than commonly.  This PR is in my TODO list since January 7th (with a low priority since I'm not the plugin's owner), but I have not processed it yet. But there're new comments from Daniel.

Best regards,
Oleg

четверг, 14 января 2016 г., 13:08:43 UTC+3 пользователь apr...@tibco.com написал:

[apr...@tibco.com]

Hi Oleg,

Thanks for the response, I was unaware that the PR was on anyone's queue for attention.

I based my request for committer rights on some advice from a Jenkins CI 'contributing' web page, following the lack of any response to the PR and my subsequent code review request.

You're right about the dates - I got confused with some other GitHub PRs and also used my first commit date by mistake.

So if a code review and PR is already scheduled, that's great and please forgive my impatience. BTW Daniel seems to have already answered his own question but I placed an explanatory note against it anyway.

Best regards,

--A

[apr...@tibco.com]

Hi Oleg,

Thanks for the code review. I implemented your suggestions and pushed the changes, which triggered CloudBees build #180. All the tests passed (including two new ones) but unfortunately the job timed out after 30 minutes, in the findbugs-maven-plugin:findbugs goal from what I could tell from the console output.

The module build itself completed in 21 minutes and the artifacts were installed in the local repository. It's unclear whether the timeout was caused by some kind of lock-up or simply that the Jenkins job timeout interval needs to be increased.

Do you have any suggestions?

Thanks,

--A