comment-ops-bot available in jenkinsci and jenkins-infra

[Tim Jacomb]

Hi all

I've created a comment-ops bot that can be used to help manage issues and pull requests on GitHub.

The features it has currently are:

• /close
• Issues only
• /label <label1,label2,...>
• /remove-label <label1,label2,...>
• /reopen
• Issues only
• /reviewer(s) <reviewer1[, ]reviewer2[, ]@org/team1...>
• /transfer <destination_repo>

It can be found at:

https://github.com/timja/github-comment-ops/

Examples:

https://github.com/jenkinsci/jenkins-infra-test-plugin/issues/42

https://github.com/jenkinsci/jenkins-infra-test-plugin/pull/40

Demo at UX sig:

https://www.youtube.com/watch?v=t1BSLRPNeQ4&t=2060s

It requires no organization permissions, which means anyone can request a review and add labels to issues and pull requests.

I plan to update the Jenkins core pull request template to suggest users do this in the near future.

Please provide any feedback here or in the issues of the repositories:

https://github.com/timja/github-comment-ops/issues

Thanks

Tim

[Daniel Beck]

On Mon, Jul 25, 2022 at 10:22 AM Tim Jacomb <timja...@gmail.com> wrote:

It requires no organization permissions, which means anyone can request a review and add labels to issues and pull requests.

What if I don't want randos on the internet messing up labeling of open PRs in repos I maintain?

[Tim Jacomb]

> What if I don't want randos on the internet messing up labeling of open PRs in repos I maintain?

There's an issue here:

https://github.com/timja/github-comment-ops/issues/54

I'm not sure how to scale that though, I thought about adding topic controls but that would mean an extra API call on each request eating into rate limits.

There could be a DSL in a config file or environment variable that excludes repositories / repositories:command, but that would mean maintainers would have to opt-out centrally.

The extent of them messing up is limited to the set of labels you have configured and you will get a notification for any action they do.

-----

At Daniel's request I've temporarily limited the repositories in the jenkinsci org to:

• jenkins
• design-library-plugin
• jenkins-infra-test-plugin

This is to gather feedback and in a couple of weeks if there's no objections we can enable globally.

Thanks

Tim

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLqpyt4qKhWcG2e-z8ht3Dg4WACTLzje_fqfoEf27dLuw%40mail.gmail.com.

[Alexander Brandes]

Hey,

> What if I don't want randos on the internet messing up labeling of open PRs in repos I maintain?

if this is going to be installed on all repositories, https://github.com/jenkinsci/jenkins/pull/6918 should be implemented and outlined in the README how to opt out.

This definitely is a nice tool, but there are people who don't want to use it and that should be respected.

> /transfer <destination_repo>

Transferring issues from one repository to an other may be restricted to organization members only.

Not everyone needs to transfer issues from A to B, given the complexicity and dependants some repositories are governed by, issues may be tranferred to the wrong directions by non org members, if they don't know what to do.

[Daniel Beck]

On Mon, Jul 25, 2022 at 12:03 PM Alexander Brandes <mc.ca...@gmail.com> wrote:

opt out.

Can we have review requests enabled by default while label changes are opt in?

[Tim Jacomb]

> Can we have review requests enabled by default while label changes are opt in?

I'm not sure if that would scale across the number of infrequently touched repositories that we have.

There's some good discussion happening in:

https://github.com/timja/github-comment-ops/pull/56

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7Pt%2BdzMxsgC__3e1BeTMdquGawX35S2KMVe2Duz8T-tsbUA%40mail.gmail.com.

[Daniel Beck]

On Mon, Jul 25, 2022 at 12:20 PM Tim Jacomb <timja...@gmail.com> wrote:

> Can we have review requests enabled by default while label changes are opt in?

I'm not sure if that would scale across the number of infrequently touched repositories that we have.

Infrequently touched repos are the problem for overly permissive defaults, since it would take forever for someone with a higher level of access to notice vandalism and fix it up.

The link does not discuss opt in, just how to define an opt out. That's the wrong question to ask.

[Tim Jacomb]

I think something like this should sort out the concerns of permissive defaults:

https://github.com/timja/github-comment-ops/pull/56#issuecomment-1193852554

something along the lines of (allowed at org and repo level):

config:
  commands:
    - name: transfer
      permission: member
      enabled: true
    - name: labels
      permission: member
      allowed_labels: ['enhancement', 'chore', 'bug']
      enabled: true
    - name: close
      enabled: false
    - name: reopen
      enabled: false

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtJNNvbCzLV%3Df%3DD1q3weXnEDA2pawndK-FNpJhW%2BVofP_w%40mail.gmail.com.