Notification Plugin patch

[Dave Hall]

Hi,

Around a month ago I submitted a PR for the notification plugin - see https://github.com/jenkinsci/notification-plugin/pull/15  There hasn’t been any response on the issue. I’d really appreciate a review.

I know enough java to be dangerous, but I don’t feel that I have the skills and/or knowledge to (co-)maintain this plugin.

Cheers

Dave

[Dave Hall]

Hi,

Thanks to Oleg and Michael for providing feedback on the PR.  I will fix the issues raised and continue the discussion on the PR.

Thanks again

Dave

[Dave Hall]

Hi,

I have updated the code in the PR based on the feedback.  It has been idle for about a week.  I'd appreciate another review at https://github.com/jenkinsci/notification-plugin/pull/15

Is it project policy to squash commits or is it ok as it is with the 3 commits?

Cheers

Dave

[Dave Hall]

Hi,

Oleg found one small issue which I've now fixed and the tests are coming back green.  Michael has reviewed and approved the fix.  Is there anything else I need to do to get this patch merged?

Cheers

Dave

[Dave Hall]

Hi,

Around 6 weeks ago my patch was applied by Steven Christou - thanks!  I appreciate everyone's input and feedback on my work.

What is the process for getting a new version of the plugin released?  

Cheers

Dave