Commit Access JenkinsCI Github

[Thabo Krick]

Hello!

I have a pending pull request for the jenkins naginator-plugin on github (https://github.com/jenkinsci/naginator-plugin/pull/17). The changes have passed the automated checks and are proven in use in our company's jenkins cluster for two weeks now.
Since I am confident with the changes and there seems to be no one available to review and merge them, I'd like to request commit access to the jenkinsci repository:

GitHub Account: thabok
Target Repository: jenkinsci:master
Source Repository: thabok:matrixrun

Thanks in advance!

Thabo Krick

[Oleg Nenashev]

Pinged Kostya Shatsou, who has released the previous versions.

понедельник, 24 августа 2015 г., 11:43:52 UTC+3 пользователь Thabo Krick написал:

[Kanstantsin Shautsou]

Firstly should be merged ikedam's refactoring, it almost reviewed.

I'm not an expert of matrix build pain, so somebody else should review and raise +1 (oleg?), then i can merge and release. 

I don't think that permissions should be provided just for merging&releasing not reviewed PR that also has no tests.

[Thabo Krick]

That's also fine with me.
The thing with testing is that the existing tests only cover the case of a freestyle job. The plugins functionality concerning matrix jobs is (so far) untested and it would have been quite an overhead to write those test for the minor changes I introduce.