What keeps CI tests from running on this Jenkinsci repository?

40 views
Skip to first unread message

Benjamin Beggs

unread,
Jul 12, 2019, 10:05:39 AM7/12/19
to jenkin...@googlegroups.com
Does anyone know why CI tests aren't running on pull requests for this repository?
I've added a Jenkinsfile to the source root directory on the master branch (https://github.com/jenkinsci/enhanced-old-build-discarder/blob/master/Jenkinsfile). No CI is coming up for my latest PR (https://github.com/jenkinsci/enhanced-old-build-discarder/pull/3).



Jeff

unread,
Jul 12, 2019, 10:32:02 AM7/12/19
to jenkin...@googlegroups.com
I wonder if it's because you're using a very old version of the parent pom?

This line specifies the parent pom version, not the version of Jenkins to build against per the comment. 

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1200949864.857781.1562940329308%40mail.yahoo.com.
For more options, visit https://groups.google.com/d/optout.

Benjamin Beggs

unread,
Jul 12, 2019, 10:37:01 AM7/12/19
to Jenkins Developers
Hmm I'm not sure if this is it. I followed the same method I used on a previous plugin I worked on: https://github.com/jenkinsci/discard-old-build-plugin/blob/master/pom.xml. I will try making a few pom.xml changes in case one of these triggers a fix.


On Friday, July 12, 2019 at 10:32:02 AM UTC-4, Jeff wrote:
I wonder if it's because you're using a very old version of the parent pom?

This line specifies the parent pom version, not the version of Jenkins to build against per the comment. 

On Fri, Jul 12, 2019 at 7:05 AM 'Benjamin Beggs' via Jenkins Developers <jenkin...@googlegroups.com> wrote:
Does anyone know why CI tests aren't running on pull requests for this repository?
I've added a Jenkinsfile to the source root directory on the master branch (https://github.com/jenkinsci/enhanced-old-build-discarder/blob/master/Jenkinsfile). No CI is coming up for my latest PR (https://github.com/jenkinsci/enhanced-old-build-discarder/pull/3).



--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

R. Tyler Croy

unread,
Jul 12, 2019, 10:38:27 AM7/12/19
to 'Benjamin Beggs' via Jenkins Developers
(replies inline)

On Fri, 12 Jul 2019, 'Benjamin Beggs' via Jenkins Developers wrote:

> Does anyone know why CI tests aren't running on pull requests for this
> repository?
> [1]https://github.com/jenkinsci/enhanced-old-build-discarder
>
> I've added a Jenkinsfile to the source root directory on the master branch ([2]
> https://github.com/jenkinsci/enhanced-old-build-discarder/blob/master/
> Jenkinsfile). No CI is coming up for my latest PR ([3]https://github.com/
> jenkinsci/enhanced-old-build-discarder/pull/3).
>


The directory name doesn't match the convention used by most (all?) the other
plugins which is $(name)-plugin.git, and thus it fails the regular expression
used by our Organization Folder.


I can change the repo name to match if you'd like
>
>
>
--
GitHub: https://github.com/rtyler

GPG Key ID: 0F2298A980EE31ACCA0A7825E5C92681BEF6CEA2
signature.asc

Benjamin Beggs

unread,
Jul 12, 2019, 10:43:45 AM7/12/19
to Jenkins Developers
Terrific, if you can do that it would be great. :)

Jeff

unread,
Jul 12, 2019, 11:16:29 AM7/12/19
to jenkin...@googlegroups.com
I don't think it was the either. Looking at the scan logs for jenkinsio.plugins, it seems like the last time GitHub was scanned was on Wednesday, and at least at that time it was ignoring the plugin.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/dd6e31cc-aba5-4626-ab33-355f41e67542%40googlegroups.com.

R. Tyler Croy

unread,
Jul 12, 2019, 1:10:34 PM7/12/19
to 'Benjamin Beggs' via Jenkins Developers
(replies inline)

On Fri, 12 Jul 2019, 'Benjamin Beggs' via Jenkins Developers wrote:

> Terrific, if you can do that it would be great. :)


Sorted:
https://ci.jenkins.io/job/Plugins/job/enhanced-old-build-discarder-plugin/
signature.asc

Benjamin Beggs

unread,
Jul 12, 2019, 2:20:56 PM7/12/19
to Jenkins Developers
Wonderful, thank you
Reply all
Reply to author
Forward
0 new messages