JUnit plugin defining adding XML Parse Configurer?
16 views
Skip to first unread message
Jaromir Hamala
unread,
Mar 20, 2017, 12:54:08 PM3/20/17
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Jenkins Developers
Hello,
I wonder what's the reason for the JUnit plugin to define a new global XML Parser Configurator? I believe the XMLEntityResolver is only useful for the junit plugin itself - when it's parsing TestNG output. Other parts of Jenkins do not benefit from this extension and I don't understand why the resolver is registered globally.
I realized this is causing performance issues: The JUnit plugin initiates a RPC to fetch parser configurators before parsing *each* test result XML file. Now image what happens when you have 1000's XML files to parse and a non-trivial network latency between a master Jenkins installation and slave agents. I had sent a PR to cache the parser configurators and it was suggested to completely remove the global registration - here is a PR with a candidate fix.