Request access for docker-workflow-plugin

142 views
Skip to first unread message

Artem Navrotskiy

unread,
Jul 22, 2019, 11:04:34 AM7/22/19
to jenkin...@googlegroups.com, d.w.n...@gmail.com
Hello,

I have some comments for docker-workflow-plugin that I would like to fix:
  • a very naive parsing Dockerfile which not a few works FROM, problem with ARG (JENKINS-44789, JENKINS-44609);
  • entrypoint/HEALTH CHECK (not working) https://issues.jenkins-ci.org/browse/JENKINS-54389);
  • there is no method to remove the container and clean the built containers after the end of the build;
  • you cannot create a container without tag;
  • too many hacks required for use shared cache directories between builds.
The fix part of the problem requires a fairly major bug fixes.
Unfortunately, it seems that the plugin is abandoned: the last commit to the master was on April 16, and there was no reaction to the trial PR for six months (https://github.com/jenkinsci/docker-workflow-plugin/pull/162).

Jenkins account: Bozaro
GitHub account: bozaro

--
Best regards,
Artem Navrotskiy
+7 (925) 095-80-41

Jesse Glick

unread,
Jul 22, 2019, 2:40:18 PM7/22/19
to Jenkins Dev
On Mon, Jul 22, 2019 at 11:04 AM Artem Navrotskiy <boz...@gmail.com> wrote:
> a very naive parsing Dockerfile

All of this parsing code could simply be deleted with no loss of
functionality. See my comment in the PR.

Really most of the plugin could be deprecated; it does more harm than good.

Artem Navrotskiy

unread,
Jul 22, 2019, 3:55:47 PM7/22/19
to jenkin...@googlegroups.com
I never use any fingerprinting features.

Correct parsing code is really complex:
- it depends on docker command line (--build-args, --target);
- I don't find ready-to-use Java Dockerfile parser.

But it’s not for me to decide whether this feature is necessary. 

пн, 22 июл. 2019 г. в 21:40, Jesse Glick <jgl...@cloudbees.com>:
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2CyjYx_PZV38UC%2Bnz5i9rSwa5e5T7WrC5XbJDvr3Jr_g%40mail.gmail.com.

Jesse Glick

unread,
Jul 22, 2019, 4:15:31 PM7/22/19
to Jenkins Dev
On Mon, Jul 22, 2019 at 3:55 PM Artem Navrotskiy <boz...@gmail.com> wrote:
> I never use any fingerprinting features.

No one does—that is my point.

Artem Navrotskiy

unread,
Jul 22, 2019, 4:35:12 PM7/22/19
to jenkin...@googlegroups.com
Also, looks like, all data for fingerprint can be get from `docker build` output.
And I think it would be much simple, than Dockerfile parsing.

пн, 22 июл. 2019 г. в 23:15, Jesse Glick <jgl...@cloudbees.com>:
On Mon, Jul 22, 2019 at 3:55 PM Artem Navrotskiy <boz...@gmail.com> wrote:
> I never use any fingerprinting features.

No one does—that is my point.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

Jesse Glick

unread,
Jul 22, 2019, 4:42:05 PM7/22/19
to Jenkins Dev
The point is that Docker fingerprints are consumed only by
https://plugins.jenkins.io/docker-traceability which was never
completed (was originally intended to provide a GUI), has few
installations, and is unmaintained. So there is no point in wasting
effort maintaining the code to _produce_ these fingerprints. The
associated steps can simply be deprecated and removed from
`Docker.groovy`, and a dozen or so old PRs closed as irrelevant.

Devin Nusbaum

unread,
Jul 29, 2019, 9:30:31 AM7/29/19
to jenkin...@googlegroups.com
Hi Artem!

Thanks for your interest - the docker-workflow plugin definitely could use more attention. That said, it's such a critical plugin that I'd like to see a few more PRs and/or reviews on this plugin from you before giving you full access.

I'll try to look at some of the open PRs over the next week or so and get a release out. In particular I think https://github.com/jenkinsci/docker-workflow-plugin/pull/180 looks like something we definitely want, since it would replace your PR and all other ones trying to fix deficiencies in the Dockerfile parsing (181, 179, 178, 176?, 173, 172, 171, 162, 151, 150, and maybe some others).

One of the main reasons this plugin doesn't get updated very often is that behavior changes always seem to cause serious regressions for some subset of users. With that in mind, we are probably not going to be merging any new features unless they include significant testing to make sure they don't cause regressions for existing users, and that they won't regress in the future. If you would like to make fundamental changes to the way the plugin works, it would probably be a better idea to fork and create a new plugin.

Feel free to ping myself (dwnusbaum) and Andrew Bayer (abayer) on your PRs and we will try to take a look. (Yes I've seen all of the pings on 162, sorry I have not had a chance to look at it yet!)

Thanks,
Devin

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

Artem Navrotskiy

unread,
Jul 31, 2019, 4:10:44 PM7/31/19
to jenkin...@googlegroups.com
Hi Devin!

I vote for the solving Dockerfile parsing issures by deprecate and remove FromFingerprintSte.
Accessing the repository is not my goal: I simply would just like to solve my problems.
Then I will prepare PRs for:
  • Add entrypoint/HEALTH CHECK support (https://issues.jenkins-ci.org/browse/JENKINS-54389);
  • Add method to remove the container and clean the built containers after the end of the build;
  • Creating a container without tag;
  • Add option for use shared cache directories between builds.
I do not promise to do it quickly, but at least I hope that this will not work in the trash.

пн, 29 июл. 2019 г. в 16:30, Devin Nusbaum <dnus...@cloudbees.com>:
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/D056192F-4EE0-4893-90B2-F913630F957A%40cloudbees.com.
Reply all
Reply to author
Forward
0 new messages