Jenkins 2.387.1 RC testing has started

[Alexander Brandes]

Hello everyone,

Latest LTS RC was made public, and it is ready to be tested. Final release is scheduled for 2023-03-08.

Please report your findings in this thread.

Download the release from: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.387.1-rc33314.b_f418c7c9f79/jenkins-war-2.387.1-rc33314.b_f418c7c9f79.war

Best regards,

Alex

[Antoine Neveux]

Hello Alex, hello everyone,

There is a regression introduced with that LTS version: [JENKINS-70662] Built-in validations are broken when inside an `optionalBlock`.

The commit that led to this regression is 5870838f690eaa06762630eceb21c40d3df0ceb8, coming from Pull Request: #7203. The regression was first delivered with Jenkins 2.376.

The particular change that led to this regression is the submit button in form/submit.jelly which was changed from <input type="submit" to <button.

The error which is faced (An invalid form control with name='' is not focusable) is likely a browser validation error (reference).

Different solutions could be imagined, among some tested:

• Adding novalidate="true" to the form tag in form.jelly works, with a concern about f:form being sufficiently commonly used to be a valid approach?
• Adding formNoValidate="true" to the submit button works as well

Other solutions could be considered, but might be more difficult to put in place?

I'm not familiar with how OSS LTS releases are managed, so could you please let me know how we could move forward with that concern? Would you like me to submit a Pull Request to core with one of these fixes?

Thanks a lot for your help and attention, have a great day!

Antoine

[Alexander Brandes]

Hey, thanks for checking. Commonly, backports happen from the master branch, so a PR with a fix would be beneficial.

Thanks!

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/jY6M9oM8tQA/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/fd65647c-f0ec-495e-9f39-3c70ec000586n%40googlegroups.com.

[Antoine Neveux]

Hey again,

Here is a Pull Request providing a fix for the regression discussed above: https://github.com/jenkinsci/jenkins/pull/7668

Let me know if anything else is needed :)

[Alexander Brandes]

Thanks, the pull request has been merged, and the commit has been backported to the stable branch.

A new RC is available at https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.387.1-rc33315.3b_778b_3e1c8d/jenkins-war-2.387.1-rc33315.3b_778b_3e1c8d.war

[Antoine Neveux]

Awesome, thanks a lot!

--

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/jY6M9oM8tQA/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d8a2d903-262b-4c03-bd36-c18bb9f8e7a5n%40googlegroups.com.

--

Antoine Neveux