Need a code review for node-js plugin
6 views
Skip to first unread message
Nikolas Falco
Dec 8, 2016, 8:05:59 AM12/8/16
to Jenkins Developers
Hi, I have complete the work of a PR by other guy done one year ago to fix issue JENKINS-26828.
Since it is my first serius commit as mantainer, could anyone please make a code review on the last commit in the branch https://github.com/jenkinsci/nodejs-plugin/commits/feature/JENKINS-26828 ?
I start from the good work of the PR by iaincoulter using as much as possible methods and logic in the DownloadFromUrlInstaller super classes, updating some snippets copied in the past from some jenkins core classes.
I've test under windows 10.
I've also test it with a windows 10 slave node and mac os (sierra) slave node with a windows 10 master node.
PS: NodeJS version used in master->slace test enviroment was v4.0.0 (has onyl msi installer for windows) and v7.2.0(a zip installer for windows is available)
Thank you
Since it is my first serius commit as mantainer, could anyone please make a code review on the last commit in the branch https://github.com/jenkinsci/nodejs-plugin/commits/feature/JENKINS-26828 ?
I start from the good work of the PR by iaincoulter using as much as possible methods and logic in the DownloadFromUrlInstaller super classes, updating some snippets copied in the past from some jenkins core classes.
I've test under windows 10.
I've also test it with a windows 10 slave node and mac os (sierra) slave node with a windows 10 master node.
PS: NodeJS version used in master->slace test enviroment was v4.0.0 (has onyl msi installer for windows) and v7.2.0(a zip installer for windows is available)
Thank you
Reply all
Reply to author
Forward
0 new messages