Commit access to saml-plugin

[The Thief]

Could you please provide me with commit access to saml-plugin repository, github account https://github.com/0xcfff. I've made a pull request about a week ago but it still has not been merged.

[Kanstantsin Shautsou]

Your change removes some variables and doesn't have any readResolve methods. This looks like a configuration breaking change. I will suggest wait plugin developer.

[Kanstantsin Shautsou]

One more update, guy under masked name and account is from my company and i provided him additional details internally. Usual expected workflow:

1) contact to author/maintainer of plugin, wait and get (or no) reply

2) After some delay week-month back to maillist and describe situation

3) Then based on situation maillist will provide commit permissions or help with review/merge/release (maybe i will do it). 
Assuming that person don't want maintain this plugin in future i suggest firstly wait initial author.

[The Thief]

Hello everyone,

10 more days passed since my initial email so I decided to write another one with details of what I'm trying to achieve.

saml-plugin, as it stated at plugin's description page, provide ability to authenticate users to Jenkins using SAML SSO protocol. On that page there is a discussion in the comments about lack of groups support. Lack of this feature makes it impossible to use this plugin together with Role-Based Strategy to configure security on per-group basis, only per-user level security is supported. So, in order to address this issue I've added groups support and made this pull request. As nobody answered me in a week, I asked for commit rights (according to this document) 

My account is https://github.com/0xcfff

You can also make me a maintainer. I don't have much knowledge in Jenkins codebase but I could try to assist if something related to this plugin breaks one day. Also I can try to add tests and one more feature to this plugin when I have time.

[Kohsuke Kawaguchi]

I've added you as a committer. Sorry for the delay.

Sounds like a reasonable effort has been spent on contacting the original author, so from my PoV you should just proceed and merge, especially if you have KostyaSha's +1 on the change itself.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAGLo7iuJCbihgYB1wCeRKdfKBHndanZKK5AxQ%3D%2BX5F%3DQYNqptg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Kohsuke Kawaguchi

[Kanstantsin Shautsou]

Email of maintainer is available in any git commit. I think it shouldn’t not be very difficult at least add him to this thread (sorry if i’m blind)?

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/fTVEubbhMBY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4zssjFu%2BT189OVw2HCz3R6pGv0GB25BkaZAoLT_HMfwNQ%40mail.gmail.com.

[Kanstantsin Shautsou]

CC'ing ben.