Junit for UI & descriptor classes

[Nikhil Bhoski]

I want to test the doCheck() blocks written in the Descriptor class. Any suggestion that how could i write Unit tests (Junits) too test these doCheck() blocks . or I should use some UI testing framework like selenium ? 

[Mark Waite]

It depends on the operations to be tested in the doCheck() method.  My order of priority has been to 

1. extract those checks into package protected methods that I called directly from a unit test, without relying on something to call the doCheck() method.  Frequently, though, that is not enough, because the checks which are being performed are  dependent on information that is only available with a running Jenkins instance
2. extract those checks into package protected methods that I call from a test that configures a running Jenkins instance using a JenkinsRule.
3. use the HTMLUnit related utilities that are provided with the Jenkins test harness
4. use Selenium or some other UI driving test harness

I'm not experienced with items 3 or 4 in that list, though I know that there are many tests in the Jenkins project that use Selenium.

You might also refer to 

• https://jenkins.io/doc/developer/testing/ - Jenkins.IO developer testing page
  
• https://javadoc.jenkins.io/component/jenkins-test-harness/?org/jvnet/hudson/test/JenkinsRule.html - JenkinsRule javadoc
  
• https://wiki.jenkins.io/display/JENKINS/Unit+Test - Jenkins Wiki unit testing page
  

Mark Waite

On Tue, Apr 16, 2019 at 4:35 AM Nikhil Bhoski <nikhil...@gmail.com> wrote:

I want to test the doCheck() blocks written in the Descriptor class. Any suggestion that how could i write Unit tests (Junits) too test these doCheck() blocks . or I should use some UI testing framework like selenium ? 

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ff26900f-91ef-4da6-bdc7-c43c793d1bc3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Thanks!

Mark Waite

[Jesse Glick]

On Tue, Apr 16, 2019 at 7:35 AM Mark Waite <mark.ea...@gmail.com> wrote:
> extract those checks into package protected methods that I call from a test that configures a running Jenkins instance using a JenkinsRule.

Or just call them directly, since they would already be `public` and
you can assert the contents of a `FormValidation` easily enough. (Look
up the descriptor instance without casts via
`Jenkins.getDescriptor(Class)`.)

Generally speaking, Stapler is designed to let you test web methods as
plain Java calls whenever reasonable, by defining specialized subtypes
of `HttpResponse` that can be used as return values, and by accepting
`@QueryParameter` and `@AncestorInPath` arguments.

Using HtmlUnit to check form validation would be relatively painful,
and overkill.

[Ullrich Hafner]

If you need some examples:

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/src/test/java/io/jenkins/plugins/analysis/core/util/ModelValidationTest.java

Note that all those methods have been extracted into a separate class so that I can use them for different steps, this is not required in your case:

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/src/main/java/io/jenkins/plugins/analysis/core/steps/IssuesRecorder.java#L1035

Typically all those validation methods can be tested with plain unit tests, so Jenkins test harness or selenium (i.e. Jenkins Acceptance Test Harness) is not needed. You just need to be carefully about not using Jenkins.getInstance() directly otherwise unit testing is not possible anymore.   

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2U1627YjDcE300TgsMUsgtDD6S0kt6OTLFjM-0suxPSg%40mail.gmail.com.