The overall appearance is well done. The whole dialog looks nice and the layout is using the available space in a perfect way.
The whole dialog uses a new save model: implicit save, i.e. all data is saved immediately. Jenkins dialogs use an explicit save model: data is only save when the user presses save (or ok). I’m not sure if this is a good thing if one plugin changes that model.
- The button texts for the days should be shown centered and the size of the buttons should be large enough so that the whole text is fitting into (Wednesday is too long):
- You should never use modal dialogs like „Are you sure you want to do something“. Just delete the setting and provide a non modal element somewhere e.g. with the text „Saturday deleted, undo“ (undo is a link does does the undo).
- When I use the slider then suddenly all texts are selected:
- When you type in a time string and hit enter then nothing happens. In this case the slider should update as well.
- When you type in an invalid date then the error highlighting is too prominent, it would make more sense to highlight just the time. (I wonder if it is really required to provide input fields for the start and end. From a usability perspective it would be much better to create a UI where the user cannot make errors by typing something invalid.)
Excluded Dates
No selection:
- The add button is outside of the box (while the same add button is inside the box of the Time range)
Edit:
- The layout should use the whole screen, even some labels are overlaying:
- When I Press Select Preset then the selection Dialog is shown outside of the screen: