New plugin: Play!Framework

52 views
Skip to first unread message

Rafael Ribeiro Rezende

unread,
Aug 15, 2014, 8:59:12 AM8/15/14
to jenkin...@googlegroups.com
Hello everyone,

I finally managed some time to finish and test the new Play plugin.
The Play!Framework plugin is designed to work with every existing version of Play, from the first non-sbt-based Play!1.x to the latest versions of Activator.

Some important details before publishing:
There is an existing play-plugin in the public repository that served the purposed in the past but isn't supported since 2011. Play! has changed quite a lot since then, so that this play-plugin is no longer functional.

I've contacted the previous contributor, Takafumi Ikeda, and he was very open to the idea of replacing his plugin.
Therefore, I forked the original plugin o Github, but ended up re-developing it from scratch.

What should I do next?

domi

unread,
Aug 15, 2014, 5:54:23 PM8/15/14
to jenkin...@googlegroups.com
If the old one is not working anymore, then you should integrate your stuff into it and try to migrate the old config to the new one, this will keep the plugin with the same pluginid and
It will keep the users from scratching there head when searching for "the right Play-Plugin"
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Rafael Ribeiro Rezende

unread,
Aug 15, 2014, 6:37:44 PM8/15/14
to jenkin...@googlegroups.com
Thanks for pointing that out.
I just noticed that the artifactId is actually play-autotest-plugin instead of the play-plugin I assumed at first due to the folder name in the jenkinsci Github.

Just fixed the artifactId to match the older one.


--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/adzmHYHaeeA/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--
Rafael R Rezende

do...@fortysix.ch

unread,
Aug 16, 2014, 8:47:39 AM8/16/14
to Jenkins Developers
the artefactId is taken from the pom.xml (which should not contain “-plugin") - the name of the git repository per convention is like <artifactId>-plugin
Domi

Rafael Ribeiro Rezende

unread,
Aug 16, 2014, 8:57:18 AM8/16/14
to jenkin...@googlegroups.com

Agreed, but the old pom.xml already had the "-plugin" in its artifactId.

If I remove it in this case, the ids won't match anymore.
Ideas?

Daniel Beck

unread,
Aug 16, 2014, 9:56:33 AM8/16/14
to jenkin...@googlegroups.com
More than 150 plugins do it wrong (i.e. have a name ending in -plugin), so that's not something to be concerned about.

Rafael Ribeiro Rezende

unread,
Aug 16, 2014, 7:51:50 PM8/16/14
to jenkin...@googlegroups.com

Or we could take the chance and fix this one at least... But I don't know if it would break any reference.

Christopher Orr

unread,
Aug 17, 2014, 8:10:54 AM8/17/14
to jenkin...@googlegroups.com
Wasn't the whole reason to rename the artifactId to keep compatibility
with the existing Play plugin?

As Domi mentioned, ideally, existing users should be able upgrade
seamlessly when you publish your version of the plugin.

So I believe the artifactId should remain the same
("play-autotest-plugin"), and the new plugin should migrate any old
config where appropriate.


On 08/17/2014 01:51 AM, Rafael Ribeiro Rezende wrote:
> Or we could take the chance and fix this one at least... But I don't
> know if it would break any reference.
>
> On Aug 16, 2014 3:56 PM, "Daniel Beck" <m...@beckweb.net
> <mailto:m...@beckweb.net>> wrote:
>
> More than 150 plugins do it wrong (i.e. have a name ending in
> -plugin), so that's not something to be concerned about.
>
> On 16.08.2014, at 14:57, Rafael Ribeiro Rezende
> <rafael...@gmail.com <mailto:rafael...@gmail.com>> wrote:
>
> > Agreed, but the old pom.xml already had the "-plugin" in its
> artifactId.
> >
> > If I remove it in this case, the ids won't match anymore.
> > Ideas?
> >
> > On Aug 16, 2014 2:47 PM, "do...@fortysix.ch
> <mailto:do...@fortysix.ch>" <do...@fortysix.ch
> <mailto:do...@fortysix.ch>> wrote:
> > the artefactId is taken from the pom.xml (which should not
> contain "-plugin") - the name of the git repository per convention
> is like <artifactId>-plugin
> > Domi
> >
> > On 16 Aug 2014, at 00:37, Rafael Ribeiro Rezende
> <rafael...@gmail.com <mailto:rafael...@gmail.com>> wrote:
> >
> >> Thanks for pointing that out.
> >> I just noticed that the artifactId is actually
> play-autotest-plugin instead of the play-plugin I assumed at first
> due to the folder name in the jenkinsci Github.
> >>
> >> Just fixed the artifactId to match the older one.
> >>
> >>
> >> On Fri, Aug 15, 2014 at 11:54 PM, domi <do...@fortysix.ch
> <mailto:do...@fortysix.ch>> wrote:
> >> If the old one is not working anymore, then you should integrate
> your stuff into it and try to migrate the old config to the new one,
> this will keep the plugin with the same pluginid and
> >> It will keep the users from scratching there head when searching
> for "the right Play-Plugin"
> >>
> >> Am 15.08.2014 um 14:59 schrieb Rafael Ribeiro Rezende
> <rafael...@gmail.com <mailto:rafael...@gmail.com>>:
> >>
> >>> Hello everyone,
> >>>
> >>> I finally managed some time to finish and test the new Play plugin.
> >>> The Play!Framework plugin is designed to work with every
> existing version of Play, from the first non-sbt-based Play!1.x to
> the latest versions of Activator.
> >>>
> >>> Some important details before publishing:
> >>> There is an existing play-plugin in the public repository that
> served the purposed in the past but isn't supported since 2011.
> Play! has changed quite a lot since then, so that this play-plugin
> is no longer functional.
> >>>
> >>> I've contacted the previous contributor, Takafumi Ikeda, and he
> was very open to the idea of replacing his plugin.
> >>> Therefore, I forked the original plugin o Github, but ended up
> re-developing it from scratch.
> >>> This is the current candidate plugin in my Github.
> >>>
> >>> What should I do next?
> >>>
> >>> --
> >>> You received this message because you are subscribed to the
> Google Groups "Jenkins Developers" group.
> >>> To unsubscribe from this group and stop receiving emails from
> it, send an email to jenkinsci-de...@googlegroups.com
> <mailto:jenkinsci-dev%2Bunsu...@googlegroups.com>.
> >>>
> >>> For more options, visit https://groups.google.com/d/optout.
> >>
> >> --
> >> You received this message because you are subscribed to a topic
> in the Google Groups "Jenkins Developers" group.
> >> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/adzmHYHaeeA/unsubscribe.
> >> To unsubscribe from this group and all its topics, send an email
> to jenkinsci-de...@googlegroups.com
> <mailto:jenkinsci-dev%2Bunsu...@googlegroups.com>.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
> >>
> >>
> >> --
> >> Rafael R Rezende
> >>
> >> --
> >> You received this message because you are subscribed to the
> Google Groups "Jenkins Developers" group.
> >> To unsubscribe from this group and stop receiving emails from
> it, send an email to jenkinsci-de...@googlegroups.com
> <mailto:jenkinsci-dev%2Bunsu...@googlegroups.com>.
> >> For more options, visit https://groups.google.com/d/optout.
> >
> >
> > --
> > You received this message because you are subscribed to a topic
> in the Google Groups "Jenkins Developers" group.
> > To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/adzmHYHaeeA/unsubscribe.
> > To unsubscribe from this group and all its topics, send an email
> to jenkinsci-de...@googlegroups.com
> <mailto:jenkinsci-dev%2Bunsu...@googlegroups.com>.
> > For more options, visit https://groups.google.com/d/optout.
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups "Jenkins Developers" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an email to jenkinsci-de...@googlegroups.com
> <mailto:jenkinsci-dev%2Bunsu...@googlegroups.com>.
> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to a topic in
> the Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/adzmHYHaeeA/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-de...@googlegroups.com
> <mailto:jenkinsci-dev%2Bunsu...@googlegroups.com>.
> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkinsci-de...@googlegroups.com
> <mailto:jenkinsci-de...@googlegroups.com>.

Rafael Ribeiro Rezende

unread,
Aug 19, 2014, 10:25:47 AM8/19/14
to jenkin...@googlegroups.com
So, let's keep it as "play-autotest-plugin".

The plugin was tested (also with master/slave config) and I'm confident it's ready to ship...
What to do next? Should I create a Pull Request?

Rafael Ribeiro Rezende

unread,
Sep 11, 2014, 5:46:13 AM9/11/14
to jenkin...@googlegroups.com
Any news here?

Sorry for resurrecting this thread.

Rafael Ribeiro Rezende

unread,
Nov 3, 2014, 9:01:34 AM11/3/14
to jenkin...@googlegroups.com
Just in case this plugin can be useful for someone, I made it available here (plus user guide):

http://rafaelrezend.github.io/play-plugin-jenkins.html
Reply all
Reply to author
Forward
0 new messages