Plugin wiki page problem - artifact/plugin id vs repo/issue URL

141 views
Skip to first unread message

farmge...@gmail.com

unread,
Dec 24, 2015, 2:10:31 AM12/24/15
to Jenkins Developers

Wiki page: https://wiki.jenkins-ci.org/display/JENKINS/Negotiate+SSO+for+Windows


My plugin page has broken links in the auto-generated "Jenkins-plugin-info:pluginId=..." block, because of discrepancies between the name of the repository/issue tracker and the artifactId set in the pom.xml file - the artifactId was set to "NegotiateSSO" before the forked repo was created, but the repo and issue tracker were set up for "negotiate-sso-plugin". I want to resolve the issue, but wanted advice on how to get it done. Options I know of:


- Try out maven's "relocation" capabilities to see if everything will link up for updates, etc.; the artifactId would be changed from "NegotiateSSO" to "Negotiate-SSO". (I can probably take care of most of this myself, but will probably need help understanding all that I need to do to make it work properly)

- Have repository, issue tracker, build job, etc. renamed to "negotiatesso-plugin". (Intervention by admins likely needed for some parts)

- Rename it, change the wiki page, and hope people find the update.


Any ideas to help resolve this?

Daniel Beck

unread,
Dec 24, 2015, 6:36:38 AM12/24/15
to jenkin...@googlegroups.com
The wiki macro supports the optional parameters jiraComponent and sourceDir (from back when everything was in SVN) to change where those point to. So I fixed this for you.

Ideally we'd rename the component and repo to match the artifact ID (at least case insensitively). I can do that if you like.

The problem with changing artifactId is that we'd need to exclude the old ID from the update sites, and existing users won't be offered plugin updates (as it would be considered a separate plugin). You could do this as well, but be aware of this limitation. Maybe now with only a few users it's still a feasible solution.
> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1d14826e-9862-4162-b865-fbfecc0d47ef%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Bryson Gibbons

unread,
Dec 24, 2015, 1:48:35 PM12/24/15
to jenkin...@googlegroups.com
Well, I would prefer to rename the component and repo, since those (if I am
thinking about it right) will break fewer things, and those things it does
break are either admin-side or developer side.

The only arguments I can see against that are the time to change the
component and repo names, and that "negotiate-sso" may better follow a
naming convention.

I was guessing that changing the artifactId would probably break updates, as
well as a few other things - the download history, for example.
You received this message because you are subscribed to a topic in the
Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/jenkinsci-dev/W-USbhOubrQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/2EEB5306-30BD-425A-9483-B297A8604755%40beckweb.net.

Daniel Beck

unread,
Dec 24, 2015, 3:50:25 PM12/24/15
to jenkin...@googlegroups.com

> On 24.12.2015, at 19:48, Bryson Gibbons <farmge...@gmail.com> wrote:
>
> The only arguments I can see against that are the time to change the component and repo names, and that "negotiate-sso" may better follow a naming convention.

We can coordinate a time that works for you. I doubt too many people rely on the existing component name, and GitHub redirects the old repo URL to the new one anyway.

> I was guessing that changing the artifactId would probably break updates, as well as a few other things - the download history, for example.

Yes, it is considered a different plugin.


Bryson Gibbons

unread,
Dec 25, 2015, 2:14:57 AM12/25/15
to jenkin...@googlegroups.com
Well, I'm assuming it wouldn't take much time to complete the rename.

What would I need to change on my end? There's the changes to the wiki page,
the change in the repo referenced in the pom.xml, and the repo url in my
local repos; is there anything else?
I don't foresee any problem with those being "incorrect" for up to a couple
of days, and I have no changes waiting to be committed right now; I am ready
to release an updated version, and would like to make the needed name
changes first.

So, pretty much anytime is okay for me, unless I am missing something.

-----Original Message-----
From: Daniel Beck
Sent: Thursday, December 24, 2015 12:50 PM
To: jenkin...@googlegroups.com
Subject: Re: Plugin wiki page problem - artifact/plugin id vs repo/issue URL


--
You received this message because you are subscribed to a topic in the
Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/jenkinsci-dev/W-USbhOubrQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/CB87AEA3-2A3F-47B2-8C1F-3D1922897051%40beckweb.net.

Bryson Gibbons

unread,
Feb 11, 2016, 2:50:45 AM2/11/16
to Jenkins Developers
Since I had access to do so, and GitHub automatically redirects repos after they are renamed, I change the name of the GitHub repo to "negotiatesso-plugin"

The Jira component could be renamed at any time; the old build job on the CloudBees Jenkins server can be handled according to whatever policies there are.
Reply all
Reply to author
Forward
0 new messages