Changing naming scheme

20 views
Skip to first unread message

Marky Jackson

unread,
Jul 21, 2019, 10:05:10 AM7/21/19
to Jenkins Developers
Hello all!
I would like to request access to the following repositories:

I would like to personally take on the work to change the naming convention for these 2 above items. I also know there will need to be some discussion surrounding this type of change but I feel this is a good place to start.I have spoken with @oleg-nenashev about this as well.


My GitHub username is markyjackson-taulia and my Jenkins ID is jequals5


Oleg Nenashev

unread,
Jul 22, 2019, 2:44:35 AM7/22/19
to Jenkins Developers
Hi Marky,

Thanks a lot for your interest! Indeed it would be great to finally fix naming, and maybe to rework the build/delivery flow to reduce the maintenance effort.
My suggestion would be to coordinate the effort in the Platform SIG.

Related changes w.r.t build on Trusted CI:
IMHO, we should do the following:
  • Introduce new "*agent" images inside the https://github.com/jenkinsci/remoting repository. Move docker-slave and docker-jnlp-slave there
    • We could keep using a separate repository, but I would rather prefer to have Remoting and its packaging under the same roof. Subject for discussion
    • Having 2 repositories does not make much sense for sure
  • Move the build and delivery of images to Trusted CI (catch: we baiscally have no access to it)
  • Introduce changelogs&Co for Docker images so that they are consumable by uders
Regarding the access, my suggestion would be to start working on the changes via pull requests. Would it work for you?

Best regards,
Oleg Nenashev

Marky Jackson

unread,
Jul 22, 2019, 4:39:55 AM7/22/19
to jenkin...@googlegroups.com
That would totally work for me and thank you

{     
    "regards" : {
         "name" : “marky”,
         "phone" : "+1 (408) 464 2965”,
         "email" : “marky.r...@gmail.com",
         "team" : “jackson5“,
 “role” : “software engineer"
     }
 }
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6408f37c-8fcc-4610-b595-7680ae3136cc%40googlegroups.com.

Jesse Glick

unread,
Jul 22, 2019, 10:08:30 AM7/22/19
to Jenkins Dev
On Mon, Jul 22, 2019 at 2:44 AM Oleg Nenashev <o.v.ne...@gmail.com> wrote:
> Introduce new "*agent" images inside the https://github.com/jenkinsci/remoting repository. Move docker-slave and docker-jnlp-slave there
>
> We could keep using a separate repository, but I would rather prefer to have Remoting and its packaging under the same roof. Subject for discussion

Makes sense to me.

While we are at it, do we really need two images? Maybe the entrypoint
could just have two modes selected by CLI option, one which makes an
inbound connection (like current `docker-jnlp-slave`), and one which
connects to stdin/out (like current `docker-slave` if you explicit add
`java -jar /usr/share/jenkins/slave.jar`).

Marky Jackson

unread,
Jul 22, 2019, 10:10:27 AM7/22/19
to Jenkins Developers
Awesome, I will work to incorporate the suggestions. 
Thanks Jesse and Oleg!

On Monday, July 22, 2019 at 7:08:30 AM UTC-7, Jesse Glick wrote:
Reply all
Reply to author
Forward
0 new messages