Plugin dependencies automatically installed

[gsim...@netflix.com]

My plugin depends on the mailer plugin (set up as described here https://wiki.jenkins-ci.org/display/JENKINS/Dependencies+among+plugins).  The plugin works, but when I install it it doesn't try and install it's dependencies. 

I hoped that Jenkins would handle installing the dependencies as long as they are listed in my plugin manifest.  For example, the git plugin installs icon-shim and other dependencies when it is installed. 

I suspect that I need to write the code to manage installing my dependencies.  Can someone point me to some example code to get me started.  I searched the git plugin project looking for something that installed other plugins but couldn't find it.

Thanks

George

[Slide]

The automatic dependency stuff only works if installing via the update center I believe.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a975a3fc-6676-4bd0-883c-9ffd776cf115%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Michael Neale]

If you install via advanced - upload plugin, then it won't install dependencies. It will tell you what is needed though. 

If you have published it to an update center and installed it via one - it WILL bring dependencies. 

You can also install it via CLI: http://jenkins-ci.361315.n4.nabble.com/Installing-Jenkins-plugins-via-API-td4639021.html 

http://stackoverflow.com/questions/7709993/how-can-i-update-jenkins-plugins-from-the-terminal

the "installNecessaryPlugins" feature may be able to help automate the dependencies. 

[Jesse Glick]

On Wed, Mar 23, 2016 at 8:50 PM, Slide <slide...@gmail.com> wrote:
> The automatic dependency stuff only works if installing via the update
> center I believe.

Or from `mvn hpi:run` when testing.

[Michael Neale]

Right - generally I like in hpi:run land until I want it in a "real" jenkins, which would be done via an update center or already likely has the required dependencies installed (this is why this doesn't come up too much I think). 

[George Simpson]

Thanks for help understanding the difference. Does anyone know the reason plugins installed via 'upload' are treated differently?

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Vf3BaCTiU3E/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/b693b12f-6127-4b68-9631-5ac3af7853c1%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

George Simpson

[Slide]

Because the dependency information is stored in the update center information. The JSON contains all the dependent plugins for a specific plugin. If you update a plugin, this information is not available.

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPHzc0PbHS%2BmXgQTL8oVbtfgvecB%3DwOR1ms0aVLH8vaoJ%3DwxrQ%40mail.gmail.com.

[George Simpson]

I see.  I noticed that dependencies were listed in the hpi manifest and assumed that was used to identify dependant plugins.

Thanks .

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVd6T5VmufdV_7pyrtOyeBqxNQi8isR-JEhKyZ4KEmZKjQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

George Simpson

[Michael Neale]

They would be in the Pom.xml and could be calculated, but it would be an expensive operation if possible.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPHzc0NF7vNXv93CpTFNcuADdoJvWYar7Z1wqE-atQso9u2JKw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

-- 

Regards, 

Michael Neale

(twitter: @michaelneale, skype: michael_d_neale)

Cell: +61 423175597

Cofounder & Engineer @ large in CTO office. 

[Daniel Beck]

On 31.03.2016, at 06:42, Michael Neale <mne...@cloudbees.com> wrote:

> They would be in the Pom.xml and could be calculated, but it would be an expensive operation if possible.

Developers edit the pom. Then maven-hpi-plugin writes them into the manifest, from which they can be read rather easily. That's what the update center does:

https://github.com/jenkinsci/backend-update-center2/blob/2aae8e491d56d4747b9581d160549ca7b56d36fc/src/main/java/org/jvnet/hudson/update_center/HPI.java#L120...L127

Transitive dependencies don't really matter, as they can be resolved by the update center when it installs the direct dependencies.

[Jesse Glick]

On Wed, Mar 30, 2016 at 10:54 PM, 'George Simpson' via Jenkins
Developers <jenkin...@googlegroups.com> wrote:
> Does anyone know the reason plugins installed via 'upload' are treated differently?

Because the upload feature is not frequently used, and no one ever
bothered to implement automatic dependency handling for this case.
There is no technical reason I know of why it would be difficult.

(Obviously if you are uploading a custom plugin with a dependency on
*another* custom plugin which you forgot to upload first, Jenkins
could do no better than to report a helpful error message, since it
would not be able to locate the dependency in the update center.)

[Slide]

FYI, I implemented this in https://github.com/jenkinsci/jenkins/pull/2209

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr37LbNcaMCW1_SbmiqLmEFkX9-kb1tJiD6KKBFnLctPBw%40mail.gmail.com.

[George Simpson]

Very cool.  Thanks all!

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Vf3BaCTiU3E/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVeXtUjea_PA95fmt-eUXF91Zh2eYaUH7Ha2m%3DTSXfwtJQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

George Simpson