potential regression in master

[jn...@cloudbees.com]

Hi all,

something is looking very fishy with the incrementals built recently.

basically no tests run for plugins (at all)

It is not that they do fail, but that maven executes zero tests.

e.g.
mvn -U clean test -s "c:\Users\jnord\.m2\settings_no_mirror.xml" -DfailIfNoTests -Djenkins.version=2.310-rc31475.ac421478662e

fails (using bouncycastle-api as the plugin under test) and that incremental version is from https://ci.jenkins.io/job/Core/job/jenkins/job/master/2817/ 

2.309 is ok - I am bisecting to try and find the specific commit - but whomever is potentially creating the release today may want to hold of (or put the release job in disabled mode on trusted.ci).

/James

[Mark Waite]

Thanks for investigating.  Weekly release is scheduled to run tomorrow.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/03fe9627-21ab-46ba-9ea2-44f237e979b3n%40googlegroups.com.

[Basil Crow]

It's jenkinsci/jenkins#5703, which pulled in jnr/jnr-ffi#252, which
updated JUnit from 4 to 5 in jnr-ffi without putting the new JUnit 5
JAR in the test scope. That means the following JARs are now
(erroneously) bundled in the Jenkins WAR:

[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.7.2:compile
[INFO] | +- org.apiguardian:apiguardian-api:jar:1.1.0:compile
[INFO] | +- org.junit.platform:junit-platform-engine:jar:1.7.2:compile
[INFO] | | +- org.opentest4j:opentest4j:jar:1.2.0:compile
[INFO] | | \- org.junit.platform:junit-platform-commons:jar:1.7.2:compile
[INFO] | \- org.junit.jupiter:junit-jupiter-api:jar:5.7.2:compile

Needless to say, we don't want these in the WAR, and their mere
presence on the classpath exposes us to SUREFIRE-1911, so we should
exclude them and file an upstream issue to fix jnr/jnr-ffi#252 by
putting these dependency in test scope.

[jn...@cloudbees.com]

You just beat me to it!

creating the PRs.

[Basil Crow]

Already done in jnr/jnr-ffi#269 jenkinsci/jenkins#5712

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/760ce5a3-4f48-4828-83fd-23fd4230879bn%40googlegroups.com.