Auto Add Group to reviewers?

40 views
Skip to first unread message

Gavin Mogan

unread,
Nov 3, 2019, 10:57:02 PM11/3/19
to jenkin...@googlegroups.com
Hey Everyone,

A while ago I added the developers team to the blueocean plugin's CODEOWNERS file, in an attempt to get more eyes on submitted PRs. I didn't realize that because the groups were private they wouldn't show up as reviewers.

Also this has to be done per project.

So I got to thinking, as an excuse to play with probot, I'd make a app that will auto add all the reviewers from $plugin-team-developers as reviewers unless there's a codeowners file.

What do people think?

Gavin

Oleg Nenashev

unread,
Nov 4, 2019, 4:22:45 AM11/4/19
to Jenkins Developers
Hi Gavin,

The group has to be public and it has to have at least exolicit Read access to the repo to be requestable as a reviewer.
If you let me know the name of the group, I can help to get it fixed.

Creating a new GitHub app might be overkill, consider using https://probot.github.io/apps/auto-assign/

BR, Oleg

Gavin

unread,
Nov 4, 2019, 4:36:57 AM11/4/19
to jenkin...@googlegroups.com
Yea I certainly looked at that one earlier. It still needs explicit setup per repo. So there's not much benefit to that over codeowners file.

I was thinking about a generic solution

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20770a2f-7d21-4a8e-abcb-6aaf928bcbec%40googlegroups.com.

Oleg Nenashev

unread,
Nov 4, 2019, 4:49:24 AM11/4/19
to JenkinsCI Developers
Then I agree, we would need a custom bot or GitHub action

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Swni67Bu7Uc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DuvB-v5C3Lnhe4ponY_Dr0MV8LQQhpZHqEebFSNJoEmOZg%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages