No activity on pull request for git-plugin

[hillebrand...@eleven.nl]

Hi all,

I made some minor modifications to the merge before build feature of the git-plugin to merge from another branch into the current and push the merge result to the current branch after the build is completed. I created a pull request on june 25th, but it has been quite since.

It is not a major change and it has good test coverage, so i think it can be merged in absence of a review. Can i get commit access to the git-plugin repository? My GitHub accountname is hillebrand.

​​

​

Regards

​,​

 

Hillebrand Gelderblom

[Oleg Nenashev]

Hi Hillebrand,

I've added several comments to your pull request. I would not vote for merging it in the current state.

BTW you can always ping the plugin maintainers if you feel the pull request hangs. Mark performs the most of maintenance work for Git plugin (which is one of the most hottest ones), so there may be slight response delays due to many activities.

Best regards,

Oleg

четверг, 30 июля 2015 г., 10:15:35 UTC+3 пользователь hillebrand...@eleven.nl написал:

[Mark Waite]

Oleg is being polite when he says that there may be a slight response delay due to many activities on the git plugin.

There are typically very long delays to requests to modify the git plugin and the git client plugin.  I'm quite conservative about accepting changes into the plugin.  It has many different active use cases among the 60 000+ installations and many ways that a seemingly straightforward change can break someone's high value use case.

Thanks,

Mark Waite

[hillebrand...@eleven.nl]

Thank you Oleg for reviewing the changes. I do not want to apear impatient about the response to my pull request. In the automatic reply from jenkinsadmin is referred to this document. It states if your pull request doesn't seem to be getting any attention after a week or so. It does not mention the possibility to ping maintainers. I will make some modifications and submit it for review again.

​​

​

Regards

​,​

 

Hillebrand

Op donderdag 30 juli 2015 09:15:35 UTC+2 schreef hillebrand...@eleven.nl:

[hillebrand...@eleven.nl]

It appears the git-plugin is already capable of merging another branch into the current one. It is probably not designed for this purpose, but after digging into the source code i found it is possible.

In the merge before build step, the Branch to merge to can be specified. Here the branch to be integrated can be specified. In the git publisher the Merge Results checkbox indicates if the merge is to be pushed. It will than push to the branch which was merged, not to the current branch being build. Instead of checking the checkbox, Branches to push to remote repositories can be specified. If the current branch being build is specified here, the merge is pushed there.

This usage may not be intuitive, but it is sufficient.

Thanks,

Hillebrand

Op donderdag 30 juli 2015 09:15:35 UTC+2 schreef hillebrand...@eleven.nl:

Hi all,