build-pipeline-plugin pull request review

24 views
Skip to first unread message

pat...@patbos.com

unread,
Jan 21, 2015, 3:30:34 AM1/21/15
to jenkin...@googlegroups.com
Hi,

I have created a PR for the build-pipeline-plugin with fixes for JENKINS-22665 and JENKINS-19755.

The PR will solve problem with the serialization of the User object within MyUserIdCause (JENKINS-22665) and after a restart all manual triggers will not show the user and just show anonymous (JENKINS-19755).
This is a big problem for our Jenkins installation

Can a committer of the plugin please review and merge this PR?

Regards
Patrik Boström

Kanstantsin Shautsou

unread,
Mar 11, 2015, 8:11:15 PM3/11/15
to jenkin...@googlegroups.com
Hi, i think this plugin suffers from retired authors/maintainers. Last time i did merge+release after they didn't reply to maillist/contacts. As i see some of them already merged two PR, but not released. I see that many people hit this bug so i can help with revewing/testing/merging/releasing again. Please contact me in IRC tomorrow and let's try decide what to do.

Kanstantsin Shautsou

unread,
Mar 18, 2015, 1:15:05 PM3/18/15
to jenkin...@googlegroups.com
As result we (patbos and me):
- released two versions with 3 fixes. 
- fixed selenium tests and added a test case for one reverted commit that broke master (it can be reopened for better review).
- added changelog (that absent before) to wiki page. I very hope that real maintainers will appear, continue resolving jira issues and provide right contacts.
This should unblock some users and prevent jenkins from broken state.
Reply all
Reply to author
Forward
0 new messages